Review Request: Fix deep copying of query schema and ORDER BY structures

Dimitrios Tanis jtanis at tanisfood.gr
Tue Mar 13 23:17:47 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104266/#review11377
-----------------------------------------------------------

Ship it!


Ship It!

- Dimitrios Tanis


On March 13, 2012, 11:13 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104266/
> -----------------------------------------------------------
> 
> (Updated March 13, 2012, 11:13 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Dimitrios Tanis.
> 
> 
> Description
> -------
> 
> KexiDB
> *Fix deep copying of query schema and ORDER BY structures
> **This removes crashes related, e.g. in reports based on queries with joins
> 
> 
> This addresses bugs 246928 and 281737.
>     http://bugs.kde.org/show_bug.cgi?id=246928
>     http://bugs.kde.org/show_bug.cgi?id=281737
> 
> 
> Diffs
> -----
> 
>   kexi/kexidb/queryschema.h 7377233 
>   kexi/kexidb/queryschema.cpp 6a7cf23 
> 
> Diff: http://git.reviewboard.kde.org/r/104266/diff/
> 
> 
> Testing
> -------
> 
> Relevant type of reports designed and previewed. Debugged query schemas after deep-copying and compared to the original - it looks identical.
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120313/46e365ba/attachment.htm>


More information about the calligra-devel mailing list