Review Request: Make parameter for KoShapeSavingContext::imageHref(...) const

Thorsten Zachmann t.zachmann at zagge.de
Mon Mar 12 14:12:19 GMT 2012


Hello Friedrich,

On Monday, March 12, 2012 14:48:29 Friedrich W. H. Kossebau wrote:
> > On March 12, 2012, 4:18 a.m., Commit Hook wrote:
> > > This review has been submitted with commit
> > > cc1069d8d8f6f782acb50d596528b5beab425793 by Friedrich W. H. Kossebau
> > > to branch master.
> 
> Okay to backport also to 2.4? And how is ABI versioning handled, BTW, as
> this is BIC?
> 

I think backporting this is not needed. Also we don't prommise any ABI 
stability yet.

Thorsten

> 
> - Friedrich W. H.
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104234/#review11305
> -----------------------------------------------------------
> 
> On March 12, 2012, 1:43 a.m., Friedrich W. H. Kossebau wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/104234/
> > -----------------------------------------------------------
> > 
> > (Updated March 12, 2012, 1:43 a.m.)
> > 
> > 
> > Review request for Calligra.
> > 
> > 
> > Description
> > -------
> > 
> > 
> > Diffs
> > -----
> > 
> >   libs/flake/KoShapeSavingContext.h f7d328c
> >   libs/flake/KoShapeSavingContext.cpp 07d4e16
> > 
> > Diff: http://git.reviewboard.kde.org/r/104234/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > 
> > Thanks,
> > 
> > Friedrich W. H. Kossebau



More information about the calligra-devel mailing list