Review Request: Fix crash in Picture shape if no picture is set yet

[Thorsten Zachmann]

Hello Friedrich,

On Monday, March 12, 2012 14:51:41 Friedrich W. H. Kossebau wrote:
> > On March 12, 2012, 6:29 a.m., Commit Hook wrote:
> > > This review has been submitted with commit
> > > 83213ec798c49d06246cf43765f89a1f3a214a15 by Friedrich W. H. Kossebau
> > > to branch master.
> 
> Okay to backport to 2.4? Or needs a separate review?

The change causing the crash is only there in master so no need to backport.

Thorsten
> 
> 
> - Friedrich W. H.
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104237/#review11309
> -----------------------------------------------------------
> 
> On March 12, 2012, 4:39 a.m., Friedrich W. H. Kossebau wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/104237/
> > -----------------------------------------------------------
> > 
> > (Updated March 12, 2012, 4:39 a.m.)
> > 
> > 
> > Review request for Calligra.
> > 
> > 
> > Description
> > -------
> > 
> > Can be seen with Calligra Stage when creating a new presentation based on
> > the template "Flood Light", editing it for a while until auto-save kicks
> > in, where it will crash in "PictureShape::saveStyle(...)" on
> > "imageData()->imageSize()" due to "imageData()" returning 0.
> > 
> > 
> > Diffs
> > -----
> > 
> >   plugins/pictureshape/PictureShape.cpp 1148641
> > 
> > Diff: http://git.reviewboard.kde.org/r/104237/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > 
> > Thanks,
> > 
> > Friedrich W. H. Kossebau