Review Request: Fix crash in Picture shape if no picture is set yet

Thorsten Zachmann t.zachmann at zagge.de
Mon Mar 12 05:05:50 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104237/#review11308
-----------------------------------------------------------

Ship it!


Nice catch. Please commit

- Thorsten Zachmann


On March 12, 2012, 4:39 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104237/
> -----------------------------------------------------------
> 
> (Updated March 12, 2012, 4:39 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Can be seen with Calligra Stage when creating a new presentation based on the template "Flood Light", editing it for a while until auto-save kicks in, where it will crash in "PictureShape::saveStyle(...)" on "imageData()->imageSize()" due to "imageData()" returning 0.
> 
> 
> Diffs
> -----
> 
>   plugins/pictureshape/PictureShape.cpp 1148641 
> 
> Diff: http://git.reviewboard.kde.org/r/104237/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120312/86a3a63f/attachment.htm>


More information about the calligra-devel mailing list