[calligra] /: Make paragraph and character dialogs actually work, and use the new visitor

[Elvis Stansvik]

2012/3/11 Inge Wallin <inge at lysator.liu.se>:
> On Saturday, March 10, 2012 10:52:04 Elvis Stansvik wrote:
>> 2012/3/9 C. Boemann <cbo at boemann.dk>:
>> > Could someone please review and take it for a spin so i can backport it
>>
>> Works fine here. Tested on single and multiple paragraphs and
>> undo/redo. Please backport.
>>
>> Side note: At the moment it's impossible to e.g. directly format e.g.
>> the underlining of a paragraph while still having the font family
>> taken from the style. Is this just a fact of life or a bug that should
>> be fixed? It should be possible right? E.g. test the following:
>>
>> - Insert a para (style Default)
>> - Make it underlined in Paragraph Settings
>> - Change font in style Default to monospace
>> - Nothing happens
>>
>> Anyways, great work and sorry for dropping the ball on this one.
>
> This should definitely work. When changing a style, all paragraphs having this
> style,*and* all paragraphs having any style which inherits the changed style
> have to be relayouted.

Right. Perhaps CharacterHighlighting::save(KoCharacterStyle *) is too
liberal with setting the font or something like that. The result is
anyway that the format that gets passed to the merge function of the
text editor has too many properties set. It will think you have
changed the font when all you changed was e.g. underline.

Elvis