Review Request: Reduce code duplication in KoTextDocumentLayout::doLayout() a bit

C. Boemann cbr at boemann.dk
Sun Mar 11 01:27:58 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104218/#review11276
-----------------------------------------------------------


except for the one bug you introduced it looks nice


libs/textlayout/KoTextDocumentLayout.cpp
<http://git.reviewboard.kde.org/r/104218/#comment9032>

    look closely and you will see you have introduced a bug here :)


- C. Boemann


On March 11, 2012, 1:19 a.m., Elvis Stansvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104218/
> -----------------------------------------------------------
> 
> (Updated March 11, 2012, 1:19 a.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Reduces code duplication a bit by moving common root area layout code into a helper function. Eases reading of the code imho.
> 
> 
> Diffs
> -----
> 
>   libs/textlayout/KoTextDocumentLayout.h cbb021c 
>   libs/textlayout/KoTextDocumentLayout.cpp 17192cb 
> 
> Diff: http://git.reviewboard.kde.org/r/104218/diff/
> 
> 
> Testing
> -------
> 
> Unit tests.
> 
> 
> Thanks,
> 
> Elvis Stansvik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120311/b89131e6/attachment.html>


More information about the calligra-devel mailing list