Review Request: Bug 290656( Meaningless action text in cell context menu) resolved
Marijn Kruisselbrink
mkruisselbrink at kde.org
Fri Mar 9 20:01:21 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104174/#review11265
-----------------------------------------------------------
Ship it!
Other than the one comment below, it looks good to me.
tables/ui/CellToolBase_p.cpp
<http://git.reviewboard.kde.org/r/104174/#comment9031>
What is this change about? The two extra separator actions don't seem to be used.
- Marijn Kruisselbrink
On March 6, 2012, 3:50 p.m., Jigar Raisinghani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104174/
> -----------------------------------------------------------
>
> (Updated March 6, 2012, 3:50 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Bug 290656 - Meaningless action text in cell context menu:
>
> Solution using patch: The confusion regarding the same label with different functionalities of "comment" in the cell context menu has been resolved.
>
>
> This addresses bug 290656.
> http://bugs.kde.org/show_bug.cgi?id=290656
>
>
> Diffs
> -----
>
> tables/ui/CellToolBase_p.cpp 5d3cf73
>
> Diff: http://git.reviewboard.kde.org/r/104174/diff/
>
>
> Testing
> -------
>
> The code has been tested and is successfully working.
>
>
> Thanks,
>
> Jigar Raisinghani
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120309/6e5798ec/attachment.htm>
More information about the calligra-devel
mailing list