Review Request: Fixes multi-line artistic text being saved with wrong coordinates for second and following lines
Boudewijn Rempt
boud at valdyas.org
Sat Mar 3 13:12:24 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104115/#review11102
-----------------------------------------------------------
Was this already pushed? Can the review be closed?
- Boudewijn Rempt
On Feb. 29, 2012, 3:50 a.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104115/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2012, 3:50 a.m.)
>
>
> Review request for Calligra and Jan Hambrecht.
>
>
> Description
> -------
>
> First innocent approach to fix that bug which Works for me (tm)
>
> No idea though yet if a fix is also needed for the case "layout() != ArtisticTextShape::Straight"?
>
>
> This addresses bug 295042.
> http://bugs.kde.org/show_bug.cgi?id=295042
>
>
> Diffs
> -----
>
> plugins/artistictextshape/ArtisticTextShape.h 05af662
> plugins/artistictextshape/ArtisticTextShape.cpp 301b6c7
>
> Diff: http://git.reviewboard.kde.org/r/104115/diff/
>
>
> Testing
> -------
>
> Created a document with a multi-line Artistic Text and saved and loaded that a few times, all lines stayed at their positions between saving and loading.
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120303/078a48b5/attachment.htm>
More information about the calligra-devel
mailing list