Review Request: Retain numeric precision in 3D view parameters.

Thorsten Zachmann t.zachmann at zagge.de
Sat Jun 30 08:01:59 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105345/#review15264
-----------------------------------------------------------

Ship it!


Ship It!

- Thorsten Zachmann


On June 30, 2012, 6:15 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105345/
> -----------------------------------------------------------
> 
> (Updated June 30, 2012, 6:15 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch fixes a problem that Zagge noted in his review of the 3D shape patch, namely that the 3D scene loses precision in a number of places. The problem was not due to the 3D shape itself, so that fix is done here instead.
> 
> Update: If nobody objects within a day I will commit this:
> 
> 
> Diffs
> -----
> 
>   libs/odf/Ko3dScene.cpp 9737dce 
> 
> Diff: http://git.reviewboard.kde.org/r/105345/diff/
> 
> 
> Testing
> -------
> 
> Tested with the 3D shape.  If you want to test without using the 3d shape branch, you can create a 3D chart in LO/OOo and test with that instead.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120630/e9e62bca/attachment.htm>


More information about the calligra-devel mailing list