Review Request: Fix saving of citation entries

Gopalakrishna Bhat gopalakbhat at gmail.com
Sat Jun 30 05:24:07 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105359/#review15260
-----------------------------------------------------------

Ship it!


Fix the issue I mentioned below and then Ship It


libs/kotext/KoInlineCite.cpp
<http://git.reviewboard.kde.org/r/105359/#comment11918>

    const QString &type


- Gopalakrishna Bhat


On June 25, 2012, 3:13 p.m., Smit Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105359/
> -----------------------------------------------------------
> 
> (Updated June 25, 2012, 3:13 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Fixes saving of citation entries. Use KoOdfBibliographyConfiguration::bibDataFields instead od bibliography types as text:bibliography-mark attributes.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/BibliographyGenerator.cpp 4404711 
>   libs/kotext/KoInlineCite.h a5c7250 
>   libs/kotext/KoInlineCite.cpp f3ba195 
> 
> Diff: http://git.reviewboard.kde.org/r/105359/diff/
> 
> 
> Testing
> -------
> 
> Tested with some documents with citations. Load/Save working as expected.
> 
> 
> Thanks,
> 
> Smit Patel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120630/9c8cfcd6/attachment.htm>


More information about the calligra-devel mailing list