Review Request: Port tables plugin to QUndo/kundo2

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105366/#review15259
-----------------------------------------------------------


Thanks. In case of such ports it may be good idea to test with valgrind's memcheck.


kexi/plugins/tables/kexitabledesignercommands.h
<http://git.reviewboard.kde.org/r/105366/#comment11911>

    Shouldn't that be kundo2commandcommand.h?



kexi/plugins/tables/kexitabledesignercommands.h
<http://git.reviewboard.kde.org/r/105366/#comment11912>

    --> KUndo2Command?



kexi/plugins/tables/kexitabledesignercommands.h
<http://git.reviewboard.kde.org/r/105366/#comment11913>

    Let's take a look at KUndo2Command:
    it has no virtual text() but setText(), so we need to move the body of text() to ctor for all classes that inherit KUndo2Command, and call setText(), less dynamic, but I hope it's OK.
    



kexi/plugins/tables/kexitabledesignercommands.h
<http://git.reviewboard.kde.org/r/105366/#comment11914>

    OK, just please remember the AlterTableHandler's actions have nothing in common with QActions - they serve for completely different purpose.



kexi/plugins/tables/kexitabledesignercommands.h
<http://git.reviewboard.kde.org/r/105366/#comment11915>

    When we're at this, I propose to port all debugString() methods to QDebug to operator<<(QDebug dbg, const [...]Command &)



kexi/plugins/tables/kexitabledesignerview_p.h
<http://git.reviewboard.kde.org/r/105366/#comment11916>

    Can we use KUndo2Group everywhere instead of CommandGroup?



kexi/plugins/tables/kexitabledesignerview_p.h
<http://git.reviewboard.kde.org/r/105366/#comment11917>

    KUndo2QStack 


- Jarosław Staniek


On June 29, 2012, 12:52 p.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105366/
> -----------------------------------------------------------
> 
> (Updated June 29, 2012, 12:52 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Ported tables plugin to QUndo (or kundo2).
> 
> Code compiles but crashes occur.  The purpose of the review is for early feedback to ensure work is in the right direction.  All crashes/problems will be fixed.
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/tables/CMakeLists.txt a29b2b944d071149f92d46b8ecc09885d4604035 
>   kexi/plugins/tables/kexilookupcolumnpage.cpp 4c459c41162400c3427cd04ef11a40f7b553f9a9 
>   kexi/plugins/tables/kexitabledesignercommands.h e906388055f508f0316b4fee3fdccb2e4379b8d8 
>   kexi/plugins/tables/kexitabledesignercommands.cpp 89bd10f939f17083cac0e9fa83c6c628fb555009 
>   kexi/plugins/tables/kexitabledesignerview.h 04710ffda0808563ebbfd73ecbbcddee72224267 
>   kexi/plugins/tables/kexitabledesignerview.cpp 8ec956d73ca7874558ac5e3a1d5bd68a18c3c815 
>   kexi/plugins/tables/kexitabledesignerview_p.h 8f2744fc52d5902f89894bef107109ff09909236 
>   kexi/plugins/tables/kexitabledesignerview_p.cpp 49af8fcfc7be103a841cf7a5ffd8abbd75e694bc 
> 
> Diff: http://git.reviewboard.kde.org/r/105366/diff/
> 
> 
> Testing
> -------
> 
> Opened an existing table, changed name, and a crash occurs because it is unable to find the undo action in the collection (i think)
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120629/929de846/attachment.htm>