Review Request: Merge branch 'master' into kexi-q3port-piggz Auto allocate selected resources to new tasks GIT_SILENT changelog Send modifiers along with the tool invocation release event. Ignore mouse press events to close the popup palette. Make sure we have end != start when we release tool invocation.

[Jarosław Staniek]

> On June 26, 2012, 9:17 p.m., Jarosław Staniek wrote:
> > I think we should use libs/kundo2/ as we do in the form designer.
> 
> Adam Pigg wrote:
>     I'll take that as a Ship-It then, as kundo2 is just QUndo from Qt 4.8.2 :)
> 
> C. Boemann wrote:
>     that may very well be right, but then again we are supposed to build on qt 4.6 too
> 
> Adam Pigg wrote:
>     Yes, but my point was that if that was the only issue, moving it to kundo2 was very little work compared to the what was involved with the port ;)

Dear Adam, I did not mean ship it... If there is crash, further work is needed as well as patch update. Also could you please set summary to a few words, not a whole paragraph? Thanks.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105366/#review15185
-----------------------------------------------------------


On June 26, 2012, 9:12 p.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105366/
> -----------------------------------------------------------
> 
> (Updated June 26, 2012, 9:12 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Merge branch 'master' into kexi-q3port-piggz
> 
> Conflicts:
> 	plugins/chartshape/dialogs/FontEditorDialog.h
> 
> Compiles now
> 
> 
> porting++
> 
> 
> Started port to QUndoGroup
> 
> 
> Removed include
> 
> 
> Fixed select on double-click
> 
> Also removed unused file
> 
> Rewrote to use tree widgets instead of list widgets
> 
> 
> Fixed ;;
> 
> 
> Added copyright
> 
> 
> Rewrote all list-items using newly defined roles Fixed visibility of 3rd column without using event filter
> 
> 
> Remove unused sorting code
> 
> 
> Allow to not set the project model to not searchable
> 
> This prevents multiple models being added when not required.
> 
> Add back the current form action
> 
> 
> Action now created properly and wors on form buttons
> 
> Also fixed crash in project navigator
> 
> Use the part class correctly
> 
> 
> Inital port away from Q3/K3
> 
> Not fully functioning yet, but compiles and runs
> Unused files removed
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/tables/CMakeLists.txt a29b2b944d071149f92d46b8ecc09885d4604035 
>   kexi/plugins/tables/kexilookupcolumnpage.cpp 4c459c41162400c3427cd04ef11a40f7b553f9a9 
>   kexi/plugins/tables/kexitabledesignercommands.h e906388055f508f0316b4fee3fdccb2e4379b8d8 
>   kexi/plugins/tables/kexitabledesignercommands.cpp 89bd10f939f17083cac0e9fa83c6c628fb555009 
>   kexi/plugins/tables/kexitabledesignerview.h 04710ffda0808563ebbfd73ecbbcddee72224267 
>   kexi/plugins/tables/kexitabledesignerview.cpp 8ec956d73ca7874558ac5e3a1d5bd68a18c3c815 
>   kexi/plugins/tables/kexitabledesignerview_p.h 8f2744fc52d5902f89894bef107109ff09909236 
>   kexi/plugins/tables/kexitabledesignerview_p.cpp 49af8fcfc7be103a841cf7a5ffd8abbd75e694bc 
> 
> Diff: http://git.reviewboard.kde.org/r/105366/diff/
> 
> 
> Testing
> -------
> 
> Opened an existing table, changed name, and a crash occurs because it is unable to find the undo action in the collection (i think)
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120629/fd3f6501/attachment.htm>