Review Request: use right mimetype for PPT files in stage desktop files

[Friedrich W. H. Kossebau]

> On June 28, 2012, 4:16 a.m., Thorsten Zachmann wrote:
> > I'm not 100% sre but when looking at the desktop files of LO they contain both mimetypes the one with the prefix and also the other. Is there a reason to not have both? Also it seems that Calligra Words has the same problem while sheets only has the one with the prefix in the list.
> 
> Friedrich W. H. Kossebau wrote:
>     I think it does not hurt to have both there, the official and (one of) the inofficial. E.g. some webservers might use an inofficial, and if the lookup mechanism does not translate it to the official mimetype, it is better to have it explicitely listed. But whatever ids are used, they need to be also matched by what the filter code checks in the end and what is listed for "X-KDE-Import=" in kpresenter_powerpoint_import.desktop :)
>     
>     The mime-database (no idea starting with which version) has all the known inofficial as alias:
>       <alias type="application/powerpoint"/>
>       <alias type="application/mspowerpoint"/>
>       <alias type="application/x-mspowerpoint"/>
>     
>     So if the minimal required version has that also, it should be fine to go just with the official. IMHO just the official one should be used in Calligra, any inofficial mimetype ids should be catched in other places. (no idea about OSX, that is why I left the plist template untouched).
>     
>     (BTW, seems there is no entry for visio files even in the latest xdg shared-mime-info db :/ )
>     
>     So shall I check and extend the patch for Words and others as well, with regard to the inofficial mimetypes for MS products?
> 
> Thorsten Zachmann wrote:
>     I would say extending the patch would make sense. As a fast start we might use the officical onces and also backport that to 2.5
> 
> C. Boemann wrote:
>     fixing this has my full support

Seems that "application/mswords" is an exception within the MS mimetypes, perhaps because registered early. All other (well, the xls and ppt ones) are in the proper namespace: "application/vnd.ms-excel" and "application/vnd.ms-powerpoint", cmp. http://www.iana.org/assignments/media-types/application/index.html

Thus the rest of the code seems fine, nothing to extend the patch with. 

So, green light for commit and backport as is?


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105370/#review15214
-----------------------------------------------------------


On June 28, 2012, 2:57 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105370/
> -----------------------------------------------------------
> 
> (Updated June 28, 2012, 2:57 a.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> Ever wondered why Stage was not offered for old PPT files in Konqueror/Dolphin?
> Reason is that stage.desktop only listed "application/mspowerpoint", but not "application/vnd.ms-powerpoint" as supported mimetype.
> And the PowerPointImport import filter only accepts "application/vnd.ms-powerpoint" as input.
> 
> Attached patch fixes this, by changing the mimetype id in stage.desktop and removing the not supported mimetype "application/mspowerpoint" from stagepart.desktop and calligraactive.desktop
> 
> Okay to backport also to 2.5?
> 
> 
> Diffs
> -----
> 
>   active/calligraactive.desktop dc79188 
>   stage/part/stage.desktop a823f9e 
>   stage/part/stagepart.desktop 8f19f93 
> 
> Diff: http://git.reviewboard.kde.org/r/105370/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120628/7c67cb15/attachment.htm>