Review Request: Compiles now

[Adam Pigg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105366/
-----------------------------------------------------------

Review request for Calligra and Jarosław Staniek.


Description
-------

Ported tables plugin from K3Command to QUndo framework.

This is an initial review request knowing that the code does not yet work, to get feedback and to see if it is the right direction.


Diffs
-----

  kexi/formeditor/kexiactionselectiondialog.h 7e2d63befc4c4f8ff160bf5ab897024f63f6f590 
  kexi/formeditor/kexiactionselectiondialog.cpp 15e59d6effe535bfe433d7e274c9e6b49ec79744 
  kexi/formeditor/kexiactionselectiondialog_p.h 8e2a1fe6820b1e41267ef50fb01aa47d70073cf1 
  kexi/plugins/tables/CMakeLists.txt a29b2b944d071149f92d46b8ecc09885d4604035 
  kexi/plugins/tables/kexilookupcolumnpage.cpp 4c459c41162400c3427cd04ef11a40f7b553f9a9 
  kexi/plugins/tables/kexitabledesignercommands.h e906388055f508f0316b4fee3fdccb2e4379b8d8 
  kexi/plugins/tables/kexitabledesignercommands.cpp 89bd10f939f17083cac0e9fa83c6c628fb555009 
  kexi/plugins/tables/kexitabledesignerview.h 04710ffda0808563ebbfd73ecbbcddee72224267 
  kexi/plugins/tables/kexitabledesignerview.cpp a801bc721d78f1fcaeadc94bb1597a4c80b1b890 
  kexi/plugins/tables/kexitabledesignerview_p.h 8f2744fc52d5902f89894bef107109ff09909236 
  kexi/plugins/tables/kexitabledesignerview_p.cpp 25f5b76e3190867fdfde7494dcdd9a558bc2e6f9 
  kexi/widget/CMakeLists.txt c4106a3be823a0e54d21ecf5a2bcf24bb8ab246e 
  kexi/widget/navigator/KexiProjectListView.h 755579bc5c57f187829f7ab3c6c49e204299524e 
  kexi/widget/navigator/KexiProjectListView.cpp 127ac941e3958c6540593acceab6abd9928bec82 
  kexi/widget/navigator/KexiProjectListViewItem.h 88a515465ea1c0ed62d23e3ce39bff00a467af19 
  kexi/widget/navigator/KexiProjectListViewItem.cpp 540aaeec5082bcf2952243ae4a7367a971a0b4a8 
  kexi/widget/navigator/KexiProjectListView_p.h 9d7b678589937b398d18ef92be676ae382b7210d 
  kexi/widget/navigator/KexiProjectNavigator.h 009ff78d4d3c9417aa90247da48601406ca06149 
  kexi/widget/navigator/KexiProjectNavigator.cpp 095422fb149ea76a2c566d66a3412e92c855bddf 
  kexi/widget/utils/klistviewitemtemplate.h 2bc47bf6ad1fd891ead25433049a08c2ccf39528 

Diff: http://git.reviewboard.kde.org/r/105366/diff/


Testing
-------

Opened an existing table, changed name, and a crash occurs because it is unable to find the undo action in the collection (i think)


Thanks,

Adam Pigg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120626/d6b196fa/attachment.htm>