Review Request: KoReport: fix save/load page margins

[Dag Andersen]

> On June 22, 2012, 8:40 p.m., Adam Pigg wrote:
> > The only thing that bothers me slightly is that all other geometry is saved in user units, such as CM, but this simplifies it slightly and works, so it should be ok.
> 
> Jarosław Staniek wrote:
>     So how does it look like after this patch applied? I'd like to see any lengths saved in one way and as close as possible to ODF...

Other geometry is saved in user units, but *not* localized. (Which imo is not a bug.)
Gemetry in odt is saveed in pt, included unit.
I propose I add pt unit to numbers in this patch and we fix the others in a separate patch.


- Dag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105305/#review15028
-----------------------------------------------------------


On June 21, 2012, 7:33 a.m., Dag Andersen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105305/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 7:33 a.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> Seems page margins never worked:
> * Saveing used namespace fo, loading used report
> * Loading expected values in pt, saving was in localized value + unit
> 
> This changes:
> * Saving to use namespace 'fo' and value in points.
> * Loading to try to load any value + optional unit (with KoUnit::parseValue()).
> 
> 
> Diffs
> -----
> 
>   libs/koreport/common/krreportdata.cpp 4adf547 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 78dda97 
> 
> Diff: http://git.reviewboard.kde.org/r/105305/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dag Andersen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120625/a3b76271/attachment.htm>