Review Request: Add support for dr3d:scene and its children

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105292/
-----------------------------------------------------------

(Updated June 25, 2012, 4:52 a.m.)


Review request for Calligra.


Changes
-------

This is version 2 of the 3D shape.  Further feedback is welcome.  It's still not ready to merge with master, see the unsolved issues below.

Fixed issues in this patch:
 - Generation of invalid odf. As far as I can tell it's valid now.
 - Losing layer information

Unsolved issues:
 - I have fixed what I thought were the issues that prevented OOo to load the saved files but it still doesn't show the 3D shapes after a roundtrip. I have no idea why this is.
 - I have not yet attempted to make the shape a inline text object which would make it work in Calligra Words.  I hope to get the help from boemann for this one.

 - Losing precision in the view parameters (dr3d:vrp and dr3d:vpn) is not actually a problem with this shape but with Ko3DScene in libs/odf.  I will fix that issue in a separate patch.


Description
-------

This patch adds rudimentary support for the dr3d:scene element and its children by introducing a 3D shape. The 3D support in ODF is pretty simple: it just defines 4 different object types: cube, sphere, extrude and rotate as well as a scene element that acts a bit like a group (draw:g).

I implemented all the object types as KoShapes because they can have styling and the scene object is also a KoShapeContainer. None of the shapes except for the scene itself can be modified now, and for the scene it's only the standard shape parameters (size, position, transform, etc).

My plan is to work in 3 stages:
1. Loading and saving - this prevents data loss
2. Rendering - this implements viewing
3. Scene and object editing
This patch implements stage 1 only.

My goal was to load dr3d:scenes and save them back with full compatibility with OOo and LO. Unfortunately I didn't manage to do that yet. 

I have tested with Karbon during the development and it loads and savs the scenes nicely. But calling KoShape::loadOdfAttributes(..., OdfAllAttributes) in karbon still loses the layer information. This makes OOo/LO not show the shapes when they are loaded again after a roundtrip through Karbon. I have not been able to analyze why Karbon saves back all shapes with layer="" when the infile clearly has layer="layout".

And if I want to make it work in Words and presumably also Stage (and Sheets?) I have to integrate it with the KoInlineObjectRegistry in kotext, something that I have also not yet managed to do. Help would be appreciated here.

But until Karbon is fixed and Words integration is done, I'm happy to receive and integrate feedback here.


Diffs (updated)
-----

  plugins/staging/CMakeLists.txt f55b316 
  plugins/staging/threedshape/CMakeLists.txt PRE-CREATION 
  plugins/staging/threedshape/Messages.sh PRE-CREATION 
  plugins/staging/threedshape/Object3D.h PRE-CREATION 
  plugins/staging/threedshape/Object3D.cpp PRE-CREATION 
  plugins/staging/threedshape/Objects.h PRE-CREATION 
  plugins/staging/threedshape/Objects.cpp PRE-CREATION 
  plugins/staging/threedshape/PLAN PRE-CREATION 
  plugins/staging/threedshape/SceneObject.h PRE-CREATION 
  plugins/staging/threedshape/SceneObject.cpp PRE-CREATION 
  plugins/staging/threedshape/ThreedShapeFactory.h PRE-CREATION 
  plugins/staging/threedshape/ThreedShapeFactory.cpp PRE-CREATION 
  plugins/staging/threedshape/ThreedShapePlugin.h PRE-CREATION 
  plugins/staging/threedshape/ThreedShapePlugin.cpp PRE-CREATION 
  plugins/staging/threedshape/threedshape.desktop PRE-CREATION 
  plugins/staging/threedshape/utils.h PRE-CREATION 
  plugins/staging/threedshape/utils.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105292/diff/


Testing
-------

Tested with a simple ODG file containing 3D objects.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120625/0b6571cf/attachment.htm>