Review Request: Fix bug 246898: Take opacity into consideration while drawing venn diagrams

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105301/#review15053
-----------------------------------------------------------

Ship it!


Nice work.


libs/flake/KoGradientBackground.cpp
<http://git.reviewboard.kde.org/r/105301/#comment11842>

    Can you please extend the comment a bit so that it is clear why you can ignore the draw:opacity in case the brush is not opaque. I had to look into the code to see it.


- Thorsten Zachmann


On June 23, 2012, 12:05 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105301/
> -----------------------------------------------------------
> 
> (Updated June 23, 2012, 12:05 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Take draw:opacity into consideration while loading and saving style:graphic-properties
> 
> 
> This addresses bug 246898.
>     http://bugs.kde.org/show_bug.cgi?id=246898
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoGradientBackground.cpp 3db1537 
>   libs/flake/KoOdfGradientBackground.cpp 4538702 
> 
> Diff: http://git.reviewboard.kde.org/r/105301/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120624/f319e405/attachment.htm>