Review Request: fixed import from csv when "Start at Line" value changed (bug302209)
Jarosław Staniek
staniek at kde.org
Fri Jun 22 21:29:48 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105309/#review15024
-----------------------------------------------------------
kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/105309/#comment11816>
or this is more clear:
return row > (firstRowForFieldNames ? 1 : 0);
- Jarosław Staniek
On June 21, 2012, 3:27 p.m., Oleg Kukharchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105309/
> -----------------------------------------------------------
>
> (Updated June 21, 2012, 3:27 p.m.)
>
>
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
>
>
> Description
> -------
>
> added check for (row - m_startline) is positive number
>
>
> This addresses bug 302209.
> http://bugs.kde.org/show_bug.cgi?id=302209
>
>
> Diffs
> -----
>
> kexi/plugins/importexport/csv/kexicsvimportdialog.cpp a1dbd648172e582f24c7ed90cfb4791bd3da3f8f
>
> Diff: http://git.reviewboard.kde.org/r/105309/diff/
>
>
> Testing
> -------
>
> tested on current master branch
>
>
> Thanks,
>
> Oleg Kukharchuk
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120622/4f889861/attachment.htm>
More information about the calligra-devel
mailing list