Review Request: Porting KexiCVSImportDialog

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105302/#review15022
-----------------------------------------------------------



kexi/plugins/importexport/csv/kexicsvimportdialog.h
<http://git.reviewboard.kde.org/r/105302/#comment11810>

    Do we need this model in .h file? Maybe it's enough to have in .cpp file (hidden symbols -> safer to change in the future)



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/105302/#comment11811>

    coding style warning: 
    please use { in a new line
    



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/105302/#comment11812>

    coding style warning: pelase add space between any method bodies



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/105302/#comment11813>

    same here: no space  
    



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/105302/#comment11814>

    coding style warning: space after ,
    


- Jarosław Staniek


On June 19, 2012, 7:40 p.m., Oleg Kukharchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105302/
> -----------------------------------------------------------
> 
> (Updated June 19, 2012, 7:40 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> * Q3Table replaced by QStandardItemModel/QTableView
> * part of logic moved into model
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h a2dcc785515c64a4b5e7fdf43e6335a23b53cf6c 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp a1dbd648172e582f24c7ed90cfb4791bd3da3f8f 
> 
> Diff: http://git.reviewboard.kde.org/r/105302/diff/
> 
> 
> Testing
> -------
> 
> tested and no problems found
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120622/cf2f039f/attachment.htm>