Review Request: KoReport: fix save/load page margins
Dag Andersen
danders at get2net.dk
Thu Jun 21 08:33:19 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105305/
-----------------------------------------------------------
(Updated June 21, 2012, 7:33 a.m.)
Review request for Calligra, Jarosław Staniek and Adam Pigg.
Changes
-------
Found another mistake in custom page size:
m_leftMargin was set instead of m_customWidth
Description
-------
Seems page margins never worked:
* Saveing used namespace fo, loading used report
* Loading expected values in pt, saving was in localized value + unit
This changes:
* Saving to use namespace 'fo' and value in points.
* Loading to try to load any value + optional unit (with KoUnit::parseValue()).
Diffs (updated)
-----
libs/koreport/common/krreportdata.cpp 4adf547
libs/koreport/wrtembed/KoReportDesigner.cpp 78dda97
Diff: http://git.reviewboard.kde.org/r/105305/diff/
Testing
-------
Thanks,
Dag Andersen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120621/3650f817/attachment.htm>
More information about the calligra-devel
mailing list