Review Request: koIcon for 2.5: Mark-up all icon names with macros, to extract and check them automatically

C. Boemann cbr at boemann.dk
Mon Jun 18 08:47:35 BST 2012 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105289/#review14821
-----------------------------------------------------------


reading your description it has a lot of nice stuff. I will surely look at it in more detail when i have time

However I'd say it's too late for 2.5 for such a big change. In general we commit to master and ask for backports, and for this it would take some testing before we should risk a backport

- C. Boemann


On June 18, 2012, 2:10 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105289/
> -----------------------------------------------------------
> 
> (Updated June 18, 2012, 2:10 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Next iteration of https://git.reviewboard.kde.org/r/104810/ , now with inital check script.
> 
> Script is tools/iconcheck/iconcheck.py, needs files oxygen-icons-4.3.5.list and calligra-icons.list,
> have to be created like described in tools/iconcheck/README
> 
> Is my very first Python code, so bare with me, improvements welcome.
> 
> Some things are still not perfect, e.g. for icons installed by Calligra the check does not take into account where the icon is used and where it is installed. So if packagers split Calligra by apps there might be icons missing, if not all packages are installed. But such things could be improved by the time, now that all used icon names are marked/fetched.
> 
> Patch also does this:
> a) fixes for the wrong usage of K/QIcon vs. pixmap (from incomplete Qt3->Qt4 porting): Q/KIcon does not have a real size, it's more kind of a factory for whatever pixmap size it is asked for, so just loading a certain icon pixmap and setting that to a KIcon/QIcon is useless, as the widget which takes the icon might request a different size. So e.g. passing a SmallIcon("icon-foo") to a button which takes a QIcon can result in badly scaled icons instead of loading the most perfect size match from the icon-set.
> 
> b) removes lots of unneeded includes, usually kiconloader.h
> 
> c) makes the API consistent for some classes, with "iconName" for a QString-based icon name and "icon" for a KIcon/QIcon type property
> 
> d) use consistently "IconSize" everywhere instead of "KIconLoader::global()->currentSize"
> 
> e) removes unused "KPrFactory::iconLoader()"
> 
> Each line has be touched manually, so should be a proper fix, but still good to have lots of eyes recheck this.
> 
> Okay to still commit this to the 2.5 branch, or want this only in master now?
> 
> 
> This addresses bug calligra/2.5.
>     http://bugs.kde.org/show_bug.cgi?id=calligra/2.5
> 
> 
> Diffs
> -----
> 
>   KoIcon.h PRE-CREATION 
>   braindump/plugins/stateshape/StateShapeFactory.cpp 782eaa5 
>   braindump/plugins/stateshape/StateToolFactory.cpp 2c8e747 
>   braindump/plugins/webshape/WebShapeFactory.cpp aec1d68 
>   braindump/plugins/webshape/WebToolFactory.cpp 9983b7d 
>   braindump/src/SectionsBoxDock.cpp 4201ab0 
>   braindump/src/View.cpp 4356654 
>   braindump/src/import/ToolDocker.cpp 1b59412 
>   flow/plugins/dockers/stencilboxdocker/StencilBoxDocker.cpp 2be1dbb 
>   karbon/plugins/flattenpath/FlattenPathPlugin.cpp 842d2a8 
>   karbon/plugins/refinepath/RefinePathPlugin.cpp e5ae760 
>   karbon/plugins/roundcorners/RoundCornersPlugin.cpp 78e76b3 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphicShapeFactory.cpp 63ead16 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyOptionWidget.cpp fe9e19a 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyToolFactory.cpp 0342e6e 
>   karbon/plugins/tools/KarbonGradientToolFactory.cpp 8f922e4 
>   karbon/plugins/tools/KarbonPatternToolFactory.cpp dd6dad6 
>   karbon/plugins/tools/KarbonPencilToolFactory.cpp c1eb00a 
>   karbon/plugins/tools/filterEffectTool/FilterEffectEditWidget.cpp 6d3480a 
>   karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.cpp bab3d7b 
>   karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsToolFactory.cpp 089fc36 
>   karbon/plugins/whirlpinch/WhirlPinchPlugin.cpp e839315 
>   karbon/ui/KarbonView.cpp d82e637 
>   karbon/ui/dialogs/KarbonConfigureDialog.cpp 6c12c45 
>   karbon/ui/dockers/KarbonLayerDocker.cpp df569b5 
>   karbon/ui/dockers/KarbonLayerModel.cpp fff70b7 
>   karbon/ui/widgets/KarbonGradientWidget.cpp 6cf5759 
>   kexi/core/KexiStandardAction.cpp 10a9cb4 
>   kexi/core/KexiWindow.h e64f9d9 
>   kexi/core/KexiWindow.cpp 5b3bc11 
>   kexi/core/kexi.h b6eb4a3 
>   kexi/core/kexi.cpp 4408e8b 
>   kexi/core/kexiactionproxy.cpp dea100f 
>   kexi/core/kexipart.cpp 7ffe8896 
>   kexi/core/kexipartinfo.h d2fb38a 
>   kexi/core/kexipartinfo.cpp a89cd38 
>   kexi/core/kexipartinfo_p.h aaa904b 
>   kexi/core/kexisharedactionhost.cpp f0b7e60 
>   kexi/core/kexitemplateloader.cpp 901994c 
>   kexi/doc/dev/CHANGELOG-Kexi-js 5adfcc1 
>   kexi/formeditor/WidgetInfo.h 8b66912 
>   kexi/formeditor/WidgetInfo.cpp 47d58e1 
>   kexi/formeditor/WidgetTreeWidget.cpp 82e4b3c 
>   kexi/formeditor/connectiondialog.cpp 88aff80 
>   kexi/formeditor/editlistviewdialog.cpp 8097fab 
>   kexi/formeditor/factories/containerfactory.cpp 97d74ac 
>   kexi/formeditor/factories/stdwidgetfactory.cpp ff4f451 
>   kexi/formeditor/form.cpp 5746780 
>   kexi/formeditor/kexiactionselectiondialog.cpp 15e59d6 
>   kexi/formeditor/libactionwidget.cpp 5c218bf 
>   kexi/formeditor/richtextdialog.cpp ee82d79 
>   kexi/formeditor/tabstopdialog.cpp 7e3b859 
>   kexi/formeditor/widgetlibrary.cpp 4850567 
>   kexi/kexidb/utils.h b7db33c 
>   kexi/kexidb/utils.cpp fee503a 
>   kexi/kexiutils/KexiAssistantPage.cpp 609a129 
>   kexi/kexiutils/SmallToolButton.h e894ec5 
>   kexi/kexiutils/SmallToolButton.cpp b023011 
>   kexi/kexiutils/debuggui.cpp d248f8f 
>   kexi/kexiutils/kmessagewidget.cpp 371e3f6 
>   kexi/kexiutils/utils.h 5d06a2d 
>   kexi/kexiutils/utils.cpp 5ddd9db 
>   kexi/main/KexiMainWindow.cpp 9180c5f 
>   kexi/main/KexiMainWindow_p.h 24e6c1d 
>   kexi/main/KexiSearchLineEdit.cpp 3534bfe 
>   kexi/main/kexifinddialog.cpp ec9f878 
>   kexi/main/kexinamedialog.h 630467a 
>   kexi/main/kexinamedialog.cpp a037d48 
>   kexi/main/startup/KexiImportExportAssistant.cpp 2d18708 
>   kexi/main/startup/KexiNewProjectAssistant.cpp ecc1a78 
>   kexi/main/startup/KexiOpenProjectAssistant.cpp 1eccd21 
>   kexi/main/startup/KexiRecentProjectsModel.cpp 663063a 
>   kexi/main/startup/KexiStartup.cpp 52fe096 
>   kexi/main/startup/KexiStartupDialog.cpp 31678b5 
>   kexi/main/startup/KexiStartupFileDialog_win.cpp 4ebe79c 
>   kexi/main/startup/KexiWelcomeAssistant.cpp 06b242d 
>   kexi/main/startup/KexiWelcomeStatusBar.cpp 86fc302 
>   kexi/migration/AlterSchemaWidget.cpp de4f459 
>   kexi/migration/importoptionsdlg.cpp a04e3c8 
>   kexi/migration/importtablewizard.cpp e4f9faa 
>   kexi/migration/importwizard.cpp e292a9a 
>   kexi/mobile/KexiMobileMainWindow.cpp a44cbfa 
>   kexi/mobile/KexiMobileToolbar.cpp 13c0a73 
>   kexi/plugins/forms/kexidatasourcepage.cpp 31923ba 
>   kexi/plugins/forms/kexidbfactory.cpp e0802bc 
>   kexi/plugins/forms/kexidbfactorybase.cpp b374169 
>   kexi/plugins/forms/kexiformmanager.cpp 0d78dff 
>   kexi/plugins/forms/kexiformpart.cpp 2a55c0a 
>   kexi/plugins/forms/widgets/kexidbimagebox.cpp e2c4890 
>   kexi/plugins/forms/widgets/kexidblineedit.cpp 1d43e9e 
>   kexi/plugins/forms/widgets/kexidbutils.cpp 7c7088e 
>   kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.cpp a14cd2d 
>   kexi/plugins/forms/widgets/webbrowser/WebBrowserFactory.cpp c5926ae 
>   kexi/plugins/importexport/csv/kexicsvexport.cpp be09ea1 
>   kexi/plugins/importexport/csv/kexicsvexportwizard.cpp 34df802 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp a1dbd64 
>   kexi/plugins/queries/kexiquerydesignersql.cpp 381ffcf 
>   kexi/plugins/queries/kexiquerydesignersqlhistory.cpp 9fab621 
>   kexi/plugins/relations/kexirelationmaindlg.h 4055f4b 
>   kexi/plugins/relations/kexirelationmaindlg.cpp 2f73edd 
>   kexi/plugins/relations/kexirelationpartimpl.cpp 3c407a6 
>   kexi/plugins/reports/kexireportdesignview.cpp 3cf1439 
>   kexi/plugins/reports/kexireportpart.cpp 6f3074e 
>   kexi/plugins/reports/kexireportview.cpp 73f66a5 
>   kexi/plugins/scripting/kexiscripting/kexiscriptdesignview.cpp 3e77ebe 
>   kexi/plugins/shapes/relationdesign/kexirelationdesignfactory.cpp 8d142d3 
>   kexi/plugins/shapes/relationdesign/kexirelationdesigntool.cpp bb632cb 
>   kexi/plugins/shapes/relationdesign/kexirelationdesigntoolfactory.cpp 4cc87bf 
>   kexi/plugins/tables/kexilookupcolumnpage.cpp 4c459c4 
>   kexi/plugins/tables/kexitabledesignerview.cpp 8ec956d 
>   kexi/plugins/tables/kexitabledesignerview_p.cpp 49af8fc 
>   kexi/plugins/tables/kexitablepart.cpp 7d9fbab 
>   kexi/tests/migration/main.cpp c512bb2 
>   kexi/tests/newapi/main.cpp 1bf9039 
>   kexi/tests/tableview/main.cpp cd2c6ae 
>   kexi/widget/KexiConnectionSelectorWidget.cpp e01b962 
>   kexi/widget/KexiDataSourceComboBox.cpp eb01f4a 
>   kexi/widget/KexiObjectInfoLabel.cpp 8366fc9 
>   kexi/widget/KexiProjectSelectorWidget.cpp a3e7da4 
>   kexi/widget/fields/KexiFieldComboBox.cpp 1bc43e6 
>   kexi/widget/fields/KexiFieldListModelItem.h a2b5be4 
>   kexi/widget/fields/KexiFieldListModelItem.cpp 0a81173 
>   kexi/widget/fields/KexiFieldListView.cpp cc5b779 
>   kexi/widget/kexidbconnectionwidget.cpp 6fa9a6e 
>   kexi/widget/kexidbdrivercombobox.cpp 2989593 
>   kexi/widget/kexiprjtypeselector.cpp e1fa54c 
>   kexi/widget/kexisectionheader.cpp b187d8b 
>   kexi/widget/navigator/KexiProjectListView.cpp 127ac94 
>   kexi/widget/navigator/KexiProjectListViewItem.cpp 540aaee 
>   kexi/widget/navigator/KexiProjectModelItem.h fda29d4 
>   kexi/widget/navigator/KexiProjectModelItem.cpp 6f2fa9f 
>   kexi/widget/navigator/KexiProjectNavigator.cpp 095422f 
>   kexi/widget/pixmapcollection.cpp 4d7c311 
>   kexi/widget/properties/KexiPropertyPaneViewBase.cpp bb58b19 
>   kexi/widget/relations/KexiRelationsTableContainer.cpp 508b3d6 
>   kexi/widget/relations/KexiRelationsView.cpp ee39b8e 
>   kexi/widget/tableview/kexidatatable.cpp 2eecce6 
>   kexi/widget/tableview/kexitableview.cpp 75abd24 
>   kexi/widget/utils/kexicontextmenuutils.cpp 355747f 
>   kexi/widget/utils/kexirecordnavigator.cpp 02a7674 
>   krita/image/generator/kis_generator_layer.cpp 73ffbc6 
>   krita/image/kis_adjustment_layer.cc 7358496 
>   krita/image/kis_base_node.h 29f7a69 
>   krita/image/kis_base_node.cpp c047ba6 
>   krita/image/kis_clone_layer.cpp 871d5d3 
>   krita/image/kis_effect_mask.h 46a5d61 
>   krita/image/kis_effect_mask.cc 20c1926 
>   krita/image/kis_external_layer_iface.h a029d2b 
>   krita/image/kis_filter_mask.cpp 0059018 
>   krita/image/kis_group_layer.cc dd3773a 
>   krita/image/kis_layer.cc 5f8d39c 
>   krita/image/kis_paint_layer.cc 46a7b26 
>   krita/image/kis_pixel_selection.h 121beb6 
>   krita/image/kis_selection_mask.h 4a60ee3 
>   krita/image/kis_selection_mask.cpp 1e9aba8 
>   krita/image/kis_transparency_mask.cc 922df76 
>   krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.h 12f0335 
>   krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc 7439511 
>   krita/plugins/extensions/bigbrother/actionseditor/kis_actions_editor.cpp da4439d 
>   krita/plugins/extensions/bigbrother/bigbrother.cc f13c7ac 
>   krita/plugins/extensions/colorrange/colorrange.cc de3a301 
>   krita/plugins/extensions/colorspaceconversion/colorspaceconversion.cc 3bb48a8 
>   krita/plugins/extensions/compose/kis_layer_compose_plugin.cpp e4130ad 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector.cpp 2476562 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_container.cpp cb2bd23 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_settings.cpp 6c423c3 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_common_colors.cpp c6467e4 
>   krita/plugins/extensions/dockers/compositiondocker/compositiondocker_dock.cpp 36fe381 
>   krita/plugins/extensions/dockers/compositiondocker/compositionmodel.cpp d6c6496 
>   krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp bdbe048 
>   krita/plugins/extensions/dockers/defaultdockers/wdgbirdeye.ui e10037a 
>   krita/plugins/extensions/dockers/tasksetdocker/tasksetdocker_dock.cpp 08f6ac6 
>   krita/plugins/extensions/dockers/tasksetdocker/tasksetmodel.cpp ac04220 
>   krita/plugins/extensions/dropshadow/kis_dropshadow.cc 59a192d 
>   krita/plugins/extensions/dropshadow/kis_dropshadow_plugin.cc 6bfff9c 
>   krita/plugins/extensions/histogram/histogram.cc 6255b9e 
>   krita/plugins/extensions/imagesize/dlg_canvassize.cc ee3d601 
>   krita/plugins/extensions/imagesize/imagesize.cc 8a068e4 
>   krita/plugins/extensions/imagesize/multilock_button.cc 9e31683 
>   krita/plugins/extensions/imagesplit/imagesplit.cpp ad10825 
>   krita/plugins/extensions/metadataeditor/kis_meta_data_editor.cc 5ec8f7d 
>   krita/plugins/extensions/modify_selection/modify_selection.cc 3e8014b 
>   krita/plugins/extensions/rotateimage/rotateimage.cc c56791a 
>   krita/plugins/extensions/separate_channels/kis_channel_separator.cc a955f04 
>   krita/plugins/extensions/separate_channels/kis_separate_channels_plugin.cc 029033d 
>   krita/plugins/extensions/shearimage/shearimage.cc 7b52ca0 
>   krita/plugins/filters/colorsfilters/colorsfilters.cpp 7b4b1b3 
>   krita/plugins/filters/embossfilter/kis_emboss_filter.cpp 58df26a 
>   krita/plugins/filters/example/example.cpp 4bdc47e 
>   krita/plugins/filters/imageenhancement/imageenhancement.cpp a4cbb21 
>   krita/plugins/filters/noisefilter/noisefilter.cpp 02d093c 
>   krita/plugins/filters/oilpaintfilter/kis_oilpaint_filter.cpp 55374b8 
>   krita/plugins/filters/pixelizefilter/kis_pixelize_filter.cpp 216cf32 
>   krita/plugins/filters/raindropsfilter/kis_raindrops_filter.cpp f187537 
>   krita/plugins/filters/randompickfilter/randompickfilter.cpp c26076d 
>   krita/plugins/filters/smalltilesfilter/kis_small_tiles_filter.cpp 38812e4 
>   krita/plugins/filters/sobelfilter/kis_sobel_filter.cpp ae996d0 
>   krita/plugins/filters/wavefilter/wavefilter.cpp 61f4f7b 
>   krita/plugins/formats/CMakeLists.txt ea786da 
>   krita/plugins/generators/solid/colorgenerator.cpp 6eeab27 
>   krita/plugins/paintops/chalk/chalk_paintop_plugin.cpp 817df1d 
>   krita/plugins/paintops/colorsmudge/colorsmudge_paintop_plugin.cpp 4429965 
>   krita/plugins/paintops/curvebrush/curve_paintop_plugin.cpp 01c11f2 
>   krita/plugins/paintops/defaultpaintops/defaultpaintops_plugin.cc b87979f 
>   krita/plugins/paintops/deform/deform_paintop_plugin.cpp d8c0c25 
>   krita/plugins/paintops/experiment/experiment_paintop_plugin.cpp 1376e9a 
>   krita/plugins/paintops/filterop/filterop.cpp ad8cb7a 
>   krita/plugins/paintops/gridbrush/grid_paintop_plugin.cpp ccd5cc2 
>   krita/plugins/paintops/hairy/hairy_paintop_plugin.cpp a472caf 
>   krita/plugins/paintops/hatching/hatching_paintop_plugin.cpp 0481ead 
>   krita/plugins/paintops/libpaintop/kis_compositeop_option.cpp 8238457 
>   krita/plugins/paintops/mypaint/mypaint_paintop_plugin.cpp 3868bc3 
>   krita/plugins/paintops/sketch/sketch_paintop_plugin.cpp a8cbb2f 
>   krita/plugins/paintops/spray/spray_paintop_plugin.cpp 2fb2cc4 
>   krita/plugins/paintops/waterymixbrush/waterymix_paintop_plugin.cpp 2b8a1be 
>   krita/plugins/tools/defaulttools/kis_tool_brush.h e64b047 
>   krita/plugins/tools/defaulttools/kis_tool_colorpicker.h 84dc9b4 
>   krita/plugins/tools/defaulttools/kis_tool_ellipse.h 32a286a 
>   krita/plugins/tools/defaulttools/kis_tool_fill.h 8ec6bb1 
>   krita/plugins/tools/defaulttools/kis_tool_gradient.h 8e24d33 
>   krita/plugins/tools/defaulttools/kis_tool_line.h 0822d6b 
>   krita/plugins/tools/defaulttools/kis_tool_measure.h 7d0e92c 
>   krita/plugins/tools/defaulttools/kis_tool_move.h d70a526 
>   krita/plugins/tools/defaulttools/kis_tool_multihand.h 36800cd 
>   krita/plugins/tools/defaulttools/kis_tool_pan.h 07b9d23 
>   krita/plugins/tools/defaulttools/kis_tool_path.h 6900fb7 
>   krita/plugins/tools/defaulttools/kis_tool_rectangle.h be3d761 
>   krita/plugins/tools/selectiontools/kis_tool_select_brush.h 431742d 
>   krita/plugins/tools/selectiontools/kis_tool_select_contiguous.h 474925c 
>   krita/plugins/tools/selectiontools/kis_tool_select_elliptical.h f924c55 
>   krita/plugins/tools/selectiontools/kis_tool_select_outline.h 7163c6b 
>   krita/plugins/tools/selectiontools/kis_tool_select_path.h 11f3e0f 
>   krita/plugins/tools/selectiontools/kis_tool_select_polygonal.h e40fd8c 
>   krita/plugins/tools/selectiontools/kis_tool_select_rectangular.h 01ac51f 
>   krita/plugins/tools/selectiontools/kis_tool_select_similar.h f573bcd 
>   krita/plugins/tools/tool_crop/kis_tool_crop.h 5e2e224 
>   krita/plugins/tools/tool_crop/tool_crop.cc 279266d 
>   krita/plugins/tools/tool_dyna/kis_tool_dyna.h 825e018 
>   krita/plugins/tools/tool_dyna/tool_dyna.cpp 967c1af 
>   krita/plugins/tools/tool_grid/kis_tool_grid.h bd2f6ae 
>   krita/plugins/tools/tool_grid/tool_grid.cc 5bd0e74 
>   krita/plugins/tools/tool_perspectivegrid/kis_tool_perspectivegrid.h 8656b32 
>   krita/plugins/tools/tool_perspectivegrid/kis_tool_perspectivegrid.cc df9b75e 
>   krita/plugins/tools/tool_perspectivegrid/tool_perspectivegrid.cc 31b1ac8 
>   krita/plugins/tools/tool_polygon/kis_tool_polygon.h d0b8713 
>   krita/plugins/tools/tool_polygon/tool_polygon.cc 597b136 
>   krita/plugins/tools/tool_polyline/kis_tool_polyline.h 5df8500 
>   krita/plugins/tools/tool_polyline/tool_polyline.cc 07b7a67 
>   krita/plugins/tools/tool_text/kis_tool_text.h ba149d3 
>   krita/plugins/tools/tool_text/tool_text.cc 2e6ae49 
>   krita/plugins/tools/tool_transform2/kis_tool_transform.h 063e299 
>   krita/plugins/tools/tool_transform2/tool_transform.cc 7996a7b 
>   krita/sdk/templates/filter/APPNAMELC.cc 531e5c2 
>   krita/ui/dialogs/kis_dlg_preferences.cc dbae42d 
>   krita/ui/flake/kis_shape_layer.cc 652ac80 
>   krita/ui/kis_categorized_item_delegate.cpp 4a58734 
>   krita/ui/kis_cursor.cc 02ec083 
>   krita/ui/kis_image_manager.cc 074e3fb 
>   krita/ui/kis_layer_manager.cc 8d0db23 
>   krita/ui/kis_node_manager.cpp aa6fb28 
>   krita/ui/kis_paintop_box.cc 28f909e 
>   krita/ui/kis_palette_manager.cpp 80df662 
>   krita/ui/kis_preference_set_registry.h 5e5d73e 
>   krita/ui/kis_statusbar.cc fd5564a 
>   krita/ui/kis_zoom_manager.cc cb88bea 
>   krita/ui/recorder/kis_node_query_path_editor.cc 05eb03e 
>   krita/ui/thememanager.cpp 62fdeb3 
>   krita/ui/tool/kis_tool_paint.cc 9f46603 
>   krita/ui/widgets/kis_color_space_selector.cc 9d55e09 
>   krita/ui/widgets/kis_custom_image_widget.cc be0a16a 
>   krita/ui/widgets/kis_floating_message.cpp c72b10c 
>   krita/ui/widgets/kis_paintop_presets_chooser_popup.cpp d23ecc0 
>   krita/ui/widgets/kis_paintop_presets_popup.cpp 0311c4b 
>   krita/ui/widgets/kis_preset_chooser.cpp 7cc468f 
>   krita/ui/widgets/kis_preset_selector_strip.cpp 61d2d5f 
>   krita/ui/widgets/kis_progress_widget.cpp 167a2f0 
>   krita/ui/widgets/kis_selection_options.cc be692fb 
>   libs/flake/KoConnectionShapeConfigWidget.cpp 5e4a8a5 
>   libs/flake/KoConnectionShapeFactory.cpp 6801934 
>   libs/flake/KoPathShapeFactory.cpp e441c93 
>   libs/flake/KoShapeFactoryBase.h ab89452 
>   libs/flake/KoShapeFactoryBase.cpp 0380da6 
>   libs/flake/KoToolFactoryBase.h ca53c93 
>   libs/flake/KoToolFactoryBase.cpp 4ec419d 
>   libs/flake/KoToolManager_p.cpp 89bf70e 
>   libs/flake/SnapGuideConfigWidget.cpp 1bb7cd2 
>   libs/flake/tools/KoCreatePathToolFactory.cpp 9d25fa5 
>   libs/flake/tools/KoPanToolFactory.cpp 07cb5ef 
>   libs/flake/tools/KoPathTool.cpp 6fb89df 
>   libs/flake/tools/KoPathToolFactory.cpp 13359b9 
>   libs/flake/tools/KoZoomToolFactory.cpp d6dcb92 
>   libs/flake/tools/KoZoomToolWidget.cpp 6196743 
>   libs/kokross/KoScriptManager.cpp 3b0fe0e 
>   libs/kokross/KoScriptingDocker.cpp e6a78a2 
>   libs/kopageapp/KoPADocumentModel.cpp 69feb88 
>   libs/kopageapp/KoPADocumentStructureDocker.cpp 18449ce 
>   libs/kopageapp/KoPAView.cpp bb53f8d 
>   libs/kopageapp/dialogs/KoPAConfigureDialog.cpp 466dcf7 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp 7b7e505 
>   libs/kopageapp/widgets/KoPageNavigator.cpp 900c3a8 
>   libs/koproperty/EditorView.cpp a442249 
>   libs/koproperty/Utils.cpp b2b641a 
>   libs/koproperty/editors/booledit.cpp aeee2af 
>   libs/koproperty/editors/cursoredit.cpp b7c072a 
>   libs/koproperty/test/test.cpp 33da9d3 
>   libs/koreport/items/check/KoReportCheckPlugin.cpp ba9bf3f 
>   libs/koreport/items/field/KoReportFieldPlugin.cpp 2a34880 
>   libs/koreport/items/image/KoReportImagePlugin.cpp f7d7b98 
>   libs/koreport/items/label/KoReportLabelPlugin.cpp 3a745af 
>   libs/koreport/items/text/KoReportTextPlugin.cpp 4d7762e 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 78dda97 
>   libs/kundo2/kundo2stack.cpp bf63eea 
>   libs/main/KoDocument.h ed91d59 
>   libs/main/KoDocument.cpp f372915 
>   libs/main/KoDocumentInfoDlg.cpp 93334c3 
>   libs/main/KoDocumentInfoPropsPage.cpp 3033c54 
>   libs/main/KoFindToolbar.cpp c650808 
>   libs/main/KoGridData.cpp 239fc73 
>   libs/main/KoMainWindow.cpp c54421f 
>   libs/main/KoOpenPane.cpp 568ce88 
>   libs/main/KoTemplateGroup.cpp 3c75fda 
>   libs/main/KoTemplateTree.cpp d278f43 
>   libs/main/KoToolDocker.cpp a392452 
>   libs/main/KoUndoStackAction.cpp 201b3c1 
>   libs/main/KoVersionDialog.cpp 09d3a51 
>   libs/main/KoView.cpp def7db9 
>   libs/main/config/KoConfigAuthorPage.cpp 09a6835 
>   libs/widgets/KoAspectButton.cpp 883ff2b 
>   libs/widgets/KoColorPopupAction.cpp 74396f3 
>   libs/widgets/KoColorSetWidget.cpp 469b880 
>   libs/widgets/KoContextBarButton.cpp 83cf549 
>   libs/widgets/KoDockWidgetTitleBar.cpp 5c25d00 
>   libs/widgets/KoDockWidgetTitleBarButton.cpp b664990 
>   libs/widgets/KoEditColorSetDialog.cpp e696288 
>   libs/widgets/KoResourceItemChooser.cpp 933652c 
>   libs/widgets/KoStrokeConfigWidget.cpp 264bb83 
>   libs/widgets/KoViewItemContextBar.cpp 7d22e25 
>   libs/widgets/KoZoomAction.cpp 3e8524f 
>   plan/about/aboutpage.cpp 3242acb 
>   plan/kptfactory.cpp 7a49e6b 
>   plan/kptinsertfiledlg.cpp 1b3ea07 
>   plan/kptview.cpp cca98f7 
>   plan/kptviewlist.cpp b72c04a 
>   plan/kptviewlistdialog.cpp 72c78dc 
>   plan/libs/models/kcalendar/kdatepicker.cpp 3a36d57 
>   plan/libs/models/kptaccountsmodel.cpp 76108c2 
>   plan/libs/models/kptnodeitemmodel.cpp 5ace17a 
>   plan/libs/models/kptrelationmodel.cpp 59fdd7a 
>   plan/libs/models/kptresourceallocationmodel.cpp e7090e3 
>   plan/libs/models/kptresourcemodel.cpp fddba1e 
>   plan/libs/models/kptschedulemodel.cpp f9c15f5 
>   plan/libs/ui/kmessagebox_copy.cpp a1f93e9 
>   plan/libs/ui/kptaccountseditor.cpp 4adb528 
>   plan/libs/ui/kptcalendareditor.cpp f3feee3 
>   plan/libs/ui/kptdependencyeditor.cpp c19a9d1 
>   plan/libs/ui/kptdocumentseditor.cpp 464951e 
>   plan/libs/ui/kpthtmlview.cpp f80eda4 
>   plan/libs/ui/kptintervaledit.cpp d211979 
>   plan/libs/ui/kptperteditor.h 4278f62 
>   plan/libs/ui/kptperteditor.cpp 4709c01 
>   plan/libs/ui/kptpertresult.h d66b05c 
>   plan/libs/ui/kptpertresult.cpp 7a6c174 
>   plan/libs/ui/kptrelationeditor.cpp 954d2e0 
>   plan/libs/ui/kptresourceallocationeditor.cpp 32c61bd 
>   plan/libs/ui/kptresourceappointmentsview.cpp dbe4cc0 
>   plan/libs/ui/kptresourceassignmentview.h 141042a 
>   plan/libs/ui/kptresourceeditor.cpp 4f83aa0 
>   plan/libs/ui/kptscheduleeditor.cpp 6d9f5a5 
>   plan/libs/ui/kpttaskeditor.cpp b8b29c5 
>   plan/libs/ui/kpttaskprogresspanel.cpp 5bf19aa 
>   plan/libs/ui/kpttaskstatusview.cpp 911a4d0 
>   plan/libs/ui/kptviewbase.cpp 1855108 
>   plan/libs/ui/kptworkpackagesendpanel.cpp 22fd92b 
>   plan/libs/ui/reports/reportdesignview.cpp ce83ed0 
>   plan/libs/ui/reports/reportexportpanel.cpp 973078d 
>   plan/libs/ui/reports/reportview.cpp ca403e7 
>   plan/workpackage/application.cpp f81c5cd 
>   plan/workpackage/main.cpp a9b3f42 
>   plan/workpackage/mainwindow.cpp dafc788 
>   plan/workpackage/taskcompletiondialog.cpp 70d1e05 
>   plan/workpackage/taskworkpackageview.cpp af24826 
>   plan/workpackage/view.cpp 89b7c82 
>   plugins/artistictextshape/ArtisticTextShapeFactory.cpp 2438b20 
>   plugins/artistictextshape/ArtisticTextTool.cpp d069e46 
>   plugins/artistictextshape/ArtisticTextToolFactory.cpp c4a9918 
>   plugins/chartshape/ChartConfigWidget.cpp 4f4a705 
>   plugins/chartshape/ChartShapeFactory.cpp b3a5014 
>   plugins/chartshape/ChartTool.cpp bab225a 
>   plugins/chartshape/ChartToolFactory.cpp 9b67999 
>   plugins/chartshape/dialogs/TableEditorDialog.cpp dc8f4f6 
>   plugins/commentshape/CommentToolFactory.cpp 9198704 
>   plugins/defaultTools/connectionTool/ConnectionTool.cpp eb94208 
>   plugins/defaultTools/connectionTool/ConnectionToolFactory.cpp 6a04221 
>   plugins/defaultTools/defaulttool/DefaultTool.cpp d64b1e1 
>   plugins/defaultTools/defaulttool/DefaultToolFactory.cpp a0e97cd 
>   plugins/defaultTools/guidestool/GuidesToolOptionWidget.cpp d2e5f72 
>   plugins/defaultTools/guidestool/InsertGuidesToolOptionWidget.cpp 21ab34b 
>   plugins/dockers/shapecollection/ShapeCollectionDocker.cpp 25d6f70 
>   plugins/dockers/strokedocker/StrokeDocker.cpp d824e1d 
>   plugins/dockers/styledocker/StyleButtonBox.cpp 17a145d 
>   plugins/formulashape/KoFormulaShapeFactory.cpp 7ce11fd 
>   plugins/formulashape/KoFormulaTool.h 6e9be42 
>   plugins/formulashape/KoFormulaTool.cpp 733d6f2 
>   plugins/formulashape/KoFormulaToolFactory.cpp d839b87 
>   plugins/musicshape/MusicShapeFactory.cpp dcf29f5 
>   plugins/musicshape/MusicTool.cpp fc1ccf0 
>   plugins/musicshape/MusicToolFactory.cpp 39d176b 
>   plugins/musicshape/SimpleEntryTool.cpp 529cf9c 
>   plugins/musicshape/SimpleEntryToolFactory.cpp a68e114 
>   plugins/musicshape/actions/AccidentalAction.cpp 0691068 
>   plugins/musicshape/actions/DotsAction.cpp 7b1bca0 
>   plugins/musicshape/actions/EraserAction.cpp b076f09 
>   plugins/musicshape/actions/NoteEntryAction.cpp 70484c8 
>   plugins/musicshape/actions/SelectionAction.cpp 2562f1c 
>   plugins/musicshape/actions/SetClefAction.cpp 34c5204 
>   plugins/musicshape/actions/TiedNoteAction.cpp 9c06fdd 
>   plugins/musicshape/dialogs/PartsWidget.cpp 4128dce 
>   plugins/pathshapes/ellipse/EllipseShapeFactory.cpp 1ad5c93 
>   plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp d820c43 
>   plugins/pathshapes/rectangle/RectangleShapeFactory.cpp c313fbc 
>   plugins/pathshapes/spiral/SpiralShapeFactory.cpp b9f902f 
>   plugins/pathshapes/star/StarShapeFactory.cpp e6a9c6d 
>   plugins/pictureshape/PictureShapeFactory.cpp 84b470d 
>   plugins/pictureshape/PictureTool.cpp bf15751 
>   plugins/pictureshape/PictureToolFactory.cpp cc47406 
>   plugins/reporting/barcode/KoReportBarcodePlugin.cpp 2f269ab 
>   plugins/reporting/chart/KoReportChartPlugin.cpp 371cb97 
>   plugins/reporting/maps/KoReportMapsPlugin.cpp 932c81d 
>   plugins/reporting/web/KoReportWebPlugin.cpp a49d7ac 
>   plugins/staging/templateshape/TemplateTool.cpp 6373aa2 
>   plugins/textediting/thesaurus/Thesaurus.cpp eeacbba 
>   plugins/textshape/FontSizeAction.cpp 10762c7 
>   plugins/textshape/ReferencesTool.cpp 564b658 
>   plugins/textshape/ReferencesToolFactory.cpp 3ec1a39 
>   plugins/textshape/ReviewToolFactory.cpp eb20719 
>   plugins/textshape/TextShapeFactory.cpp 4e6d817 
>   plugins/textshape/TextTool.cpp 302ca80 
>   plugins/textshape/TextToolFactory.cpp 4c0d3a3 
>   plugins/textshape/dialogs/CharacterHighlighting.cpp 8807cfd 
>   plugins/textshape/dialogs/LanguageTab.cpp a50d611 
>   plugins/textshape/dialogs/QuickTableButton.cpp 1086b5a 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp 18573e8 
>   plugins/textshape/dialogs/SimpleTableWidget.cpp acf5734 
>   plugins/textshape/dialogs/StylesComboPreview.cpp a502bc5 
>   plugins/textshape/dialogs/StylesDelegate.cpp fc3c1f8 
>   plugins/textshape/dialogs/StylesModel.h 907ae04 
>   plugins/textshape/dialogs/StylesModel.cpp ad231d1 
>   plugins/textshape/tests/TestChangeTrackedDelete.cpp 7cb6b15 
>   plugins/variables/FixedDateFormat.cpp f865821 
>   plugins/vectorshape/VectorShapeFactory.cpp 07e02ae 
>   plugins/vectorshape/VectorTool.cpp 79742fd 
>   plugins/vectorshape/VectorToolFactory.cpp 04212c6 
>   plugins/videoshape/VideoShape.cpp 97b26f0 
>   plugins/videoshape/VideoShapeFactory.cpp 7235eaf 
>   sheets/Global.h b5421b4 
>   sheets/MapModel.cpp 4aa9fbd 
>   sheets/Style.cpp 7e32a29 
>   sheets/dialogs/ConsolidateDialog.cpp b4869e2 
>   sheets/dialogs/DocumentSettingsDialog.cpp 6b76bff 
>   sheets/dialogs/FormulaDialog.cpp d445694 
>   sheets/dialogs/LayoutDialog.h ea5fef6 
>   sheets/dialogs/LayoutDialog.cpp 7372d38 
>   sheets/dialogs/LinkDialog.cpp ae01286 
>   sheets/dialogs/SortDialog.cpp 4b0fd21 
>   sheets/part/CellToolFactory.h 062c9cc 
>   sheets/part/CellToolFactory.cpp 4573c10 
>   sheets/part/ToolRegistry.cpp d08ff7e 
>   sheets/part/View.cpp c6d6b3c 
>   sheets/part/dialogs/PreferenceDialog.cpp e77f7ea 
>   sheets/part/dialogs/SheetSelectPage.cpp 69de4a3 
>   sheets/plugins/calendar/CalendarTool.cpp 1812e8f 
>   sheets/plugins/calendar/CalendarToolWidget.cpp ce13dd7 
>   sheets/shape/SheetsEditor.cpp 7967966 
>   sheets/shape/TableShapeFactory.cpp 98102a6 
>   sheets/shape/TableTool.cpp 8c6d277 
>   sheets/shape/TableToolFactory.cpp 5eb228c 
>   sheets/ui/CellEditorDocker.cpp f8fd9c8 
>   sheets/ui/CellToolBase.cpp 89b79f9 
>   sheets/ui/CellToolBase_p.cpp bbfe480 
>   sheets/ui/ExternalEditor.cpp 082c38a 
>   sheets/ui/MapViewModel.cpp 2c2c669 
>   sheets/ui/RegionSelector.cpp 028f234 
>   stage/part/KPrCustomSlideShowsModel.cpp 9014886 
>   stage/part/KPrFactory.h d5df9c8 
>   stage/part/KPrFactory.cpp f7f7c94 
>   stage/part/KPrPresentationBlackStrategy.cpp d64e9c7 
>   stage/part/KPrPresentationDrawStrategy.cpp fa15b3c 
>   stage/part/KPrPresenterViewInterface.cpp e6aafb3 
>   stage/part/KPrPresenterViewToolWidget.cpp c5f294a 
>   stage/part/KPrPresenterViewWidget.cpp 65fd5be 
>   stage/part/KPrSlidesSorterDocumentModel.cpp 084e59a 
>   stage/part/KPrView.cpp 1606dfa 
>   stage/part/KPrViewModeSlidesSorter.cpp 29d22b3 
>   stage/part/pagelayout/KPrPageLayout.cpp e7bd8be 
>   stage/part/tools/animationtool/KPrAnimationToolFactory.cpp 867d806 
>   stage/part/ui/KPrPresentationToolWidget.cpp 5adf7f6 
>   tools/iconcheck/README PRE-CREATION 
>   tools/iconcheck/iconcheck.py PRE-CREATION 
>   words/part/KWView.cpp e501cee 
>   words/part/dialogs/KWConfigureDialog.cpp 93929aa 
>   words/part/dockers/KWRdfDocker.cpp 0a44e53 
>   words/part/pagetool/KWPageToolFactory.cpp c0680ab 
> 
> Diff: http://git.reviewboard.kde.org/r/105289/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120618/e1969f60/attachment.htm>

More information about the calligra-devel mailing list