Review Request: Implement the basics of the Canvas Interaction proposal

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105250/#review14759
-----------------------------------------------------------

Ship it!


Good stuff! This works so much better than yesterday, it's smooth and I cannot find the bugs anymore. Just two niggles, modifier + stylus button should work, and autorepeat (as we discussed on irc, just mentioning here for the log)

- Boudewijn Rempt


On June 15, 2012, 12:59 p.m., Arjen Hiemstra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105250/
> -----------------------------------------------------------
> 
> (Updated June 15, 2012, 12:59 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Description
> -------
> 
> This patch is a squashed patch of all the current changes in the krita-canvasinteraction-ahiemstra branch. It implements the basics of my canvas interaction proposal. 
> 
> With these changes, the input to the canvas is now handled by the class KisInputManager. This class installs an event filter and uses the events to try and match certain shortcuts. When a match is found, an action associated with that shortcut gets activated and perfoms whatever the action is meant to do. These changes implement 7 different actions that cover most of what used to be performed by the canvas.
> 
> Known Issues:
> - The recognition code is not yet very robust. Especially the shortcuts configured as Control + Some Button or Key seem hard to trigger.
> - The "Alternate Invocation" action with the normal brush tool somehow does not get deactivated correctly.
> - A KAction is added for setting up the mirror axis, but it fails. I do not know why since the code is, as far as I can see, the same as the old code.
> - Due to the way recognition is currently done, a single click on the canvas will not paint.
> - The Pan, Rotate and Zoom actions may be a little jumpy, due to them using incorrect mouse positions.
> 
> Still To Do:
> - Loading shortcut configuration from a configuration file instead of hardcoding them.
> - Create a configuration UI for shortcut configuration.
> - Implement overlay widgets for the Pan, Rotate and Zoom actions.
> 
> 
> Diffs
> -----
> 
>   krita/ui/CMakeLists.txt 212f515 
>   krita/ui/canvas/kis_canvas2.cpp 15c8c68 
>   krita/ui/canvas/kis_canvas_widget_base.h d9a92fd 
>   krita/ui/canvas/kis_canvas_widget_base.cpp 4ee3bb6 
>   krita/ui/canvas/kis_qpainter_canvas.h a70f463 
>   krita/ui/canvas/kis_qpainter_canvas.cpp c2cd5f6 
>   krita/ui/input/kis_abstract_input_action.h PRE-CREATION 
>   krita/ui/input/kis_abstract_input_action.cpp PRE-CREATION 
>   krita/ui/input/kis_alternate_invocation_action.h PRE-CREATION 
>   krita/ui/input/kis_alternate_invocation_action.cpp PRE-CREATION 
>   krita/ui/input/kis_change_primary_setting_action.h PRE-CREATION 
>   krita/ui/input/kis_change_primary_setting_action.cpp PRE-CREATION 
>   krita/ui/input/kis_input_manager.h PRE-CREATION 
>   krita/ui/input/kis_input_manager.cpp PRE-CREATION 
>   krita/ui/input/kis_pan_action.h PRE-CREATION 
>   krita/ui/input/kis_pan_action.cpp PRE-CREATION 
>   krita/ui/input/kis_rotate_canvas_action.h PRE-CREATION 
>   krita/ui/input/kis_rotate_canvas_action.cpp PRE-CREATION 
>   krita/ui/input/kis_shortcut.h PRE-CREATION 
>   krita/ui/input/kis_shortcut.cpp PRE-CREATION 
>   krita/ui/input/kis_show_palette_action.h PRE-CREATION 
>   krita/ui/input/kis_show_palette_action.cpp PRE-CREATION 
>   krita/ui/input/kis_tool_invocation_action.h PRE-CREATION 
>   krita/ui/input/kis_tool_invocation_action.cpp PRE-CREATION 
>   krita/ui/input/kis_zoom_action.h PRE-CREATION 
>   krita/ui/input/kis_zoom_action.cpp PRE-CREATION 
>   krita/ui/opengl/kis_opengl_canvas2.h 7523e92 
>   krita/ui/opengl/kis_opengl_canvas2.cpp d125f5a 
>   krita/ui/tool/kis_tool.cc eca749a 
>   krita/ui/tool/kis_tool_paint.cc 61be742 
> 
> Diff: http://git.reviewboard.kde.org/r/105250/diff/
> 
> 
> Testing
> -------
> 
> I have performed quite some drawing using this code. The basic concept works very well and most of the actions are fairly intuitive, but the recognition code needs improvement.
> 
> 
> Thanks,
> 
> Arjen Hiemstra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120615/196b2329/attachment.htm>