Review Request: New integration design to connection tool

Yue Liu opuspace at gmail.com
Fri Jun 15 13:22:38 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105237/
-----------------------------------------------------------

(Updated June 15, 2012, 12:22 p.m.)


Review request for Calligra.


Description
-------

The original design to connection tool used several edit mode to manipulate connections and connection points, it works but user may not find out how to use it easily, so I added an option widget providing tool buttons to the usual actions user might want to use when manipulating connections, and disabled the double click to change edit mode feature in case user may accidentally enter unintended edit modes.

Other improvements are,
double click blank region to back to default tool, so now connection tool is consistent with path tool in this behavior,
added text box to new connectors created by default.


Diffs (updated)
-----

  libs/flake/KoConnectionShape.h 37984022f0154696d47385c5119f559978f9d9f2 
  libs/flake/KoConnectionShapeConfigWidget.h f3947d412533f516bd04f3beb1dac0d224107d74 
  libs/flake/KoConnectionShapeConfigWidget.cpp c4e46cc09e4536401f5f66dcfea09ee25821a6b5 
  pics/oxygen/ox16-action-curve-connector.png PRE-CREATION 
  pics/oxygen/ox16-action-lines-connector.png PRE-CREATION 
  pics/oxygen/ox16-action-standard-connector.png PRE-CREATION 
  pics/oxygen/ox16-action-straight-connector.png PRE-CREATION 
  plugins/defaultTools/connectionTool/ConnectionPointWidget.cpp 42f88225364dbc7d8dce726521bc9a15b8f889ef 
  plugins/defaultTools/connectionTool/ConnectionPointWidget.ui 824814dc072d012257ef74e485f41c9a9a2bfd3f 
  plugins/defaultTools/connectionTool/ConnectionTool.h 172eb7fd919b22ee60d2c3a594f09bebed43eea8 
  plugins/defaultTools/connectionTool/ConnectionTool.cpp d95a34f02850719b13c7acbf5f57381fd53c6908 

Diff: http://git.reviewboard.kde.org/r/105237/diff/


Testing
-------

Tested in every application. connector path update not work in Words, but I think that's irrelevant with my patch.


Thanks,

Yue Liu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120615/88453bb0/attachment.htm>


More information about the calligra-devel mailing list