Review Request: Bibliography database UI
Jaroslaw Staniek
staniek at kde.org
Thu Jun 14 05:23:40 BST 2012
I didn't read the code, but do you use kexidb for the db creation and
data access? I'm asking because of reuse principle. I can help with
that for 2.6.
On 14/06/2012, Gopalakrishna Bhat <gopalakbhat at gmail.com> wrote:
>
>
>> On June 13, 2012, 9:50 p.m., C. Boemann wrote:
>> > i've not tested it either, but to me it sounds like it's 'just' the
>> > basic database ui. We still miss any kind of connection to engines.
>> > Therefore I wonder if it has any values to users right now? And if not
>> > then I don't think we should try to rush in a merge to master before we
>> > branch for 2.5.
>> >
>> > Any thoughts?
>
> Yeah, It is a database UI. Since the branching is t'row I doubt merging will
> happen before that. Anyways I too think it should be done after branching.
>
>
> - Gopalakrishna
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105240/#review14710
> -----------------------------------------------------------
>
>
> On June 13, 2012, 12:12 p.m., Smit Patel wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/105240/
>> -----------------------------------------------------------
>>
>> (Updated June 13, 2012, 12:12 p.m.)
>>
>>
>> Review request for Calligra.
>>
>>
>> Description
>> -------
>>
>> Bibliography database UI.
>> 1) create/load/save/edit table saved in SQLite file
>> 2) Search in database
>> 3) Apply custom filters to database
>> 4) Integrated this UI with existing insert citation for edit/create cite
>> in database
>>
>>
>> Diffs
>> -----
>>
>> CMakeLists.txt 33cdabb
>> libs/kotext/BibliographyGenerator.cpp 15808cb
>> libs/kotext/KoInlineCite.h df4a2e9
>> libs/kotext/KoInlineCite.cpp 6d949da
>> libs/kotext/KoInlineTextObjectManager.cpp e82664d
>> libs/kotext/KoTextEditor.cpp b3e16ba
>> plugins/chartshape/TODO 94efb62
>> plugins/textshape/CMakeLists.txt 6253323
>> plugins/textshape/ReferencesTool.h 491b933
>> plugins/textshape/ReferencesTool.cpp 564b658
>> plugins/textshape/dialogs/BibliographyDatabaseWindow.h PRE-CREATION
>> plugins/textshape/dialogs/BibliographyDatabaseWindow.cpp PRE-CREATION
>> plugins/textshape/dialogs/BibliographyDatabaseWindow.ui PRE-CREATION
>> plugins/textshape/dialogs/BibliographyDb.h PRE-CREATION
>> plugins/textshape/dialogs/BibliographyDb.cpp PRE-CREATION
>> plugins/textshape/dialogs/CitationInsertionDialog.h f5eac0b6
>> plugins/textshape/dialogs/CitationInsertionDialog.cpp 14f9429
>> plugins/textshape/dialogs/CitationInsertionDialog.ui 8f10f64
>> plugins/textshape/dialogs/EditFiltersDialog.h PRE-CREATION
>> plugins/textshape/dialogs/EditFiltersDialog.cpp PRE-CREATION
>> plugins/textshape/dialogs/InsertCitationDialog.h PRE-CREATION
>> plugins/textshape/dialogs/InsertCitationDialog.cpp PRE-CREATION
>> plugins/textshape/dialogs/InsertCitationDialog.ui PRE-CREATION
>> plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp 2d1c1de
>> plugins/textshape/dialogs/SimpleCitationBibliographyWidget.ui 55699bb
>>
>> Diff: http://git.reviewboard.kde.org/r/105240/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Smit Patel
>>
>>
>
>
--
regards / pozdrawiam, Jaroslaw Staniek
http://www.linkedin.com/in/jstaniek
Kexi & Calligra (kexi-project.org, identi.ca/kexi, calligra-suite.org)
KDE Software Development Platform on MS Windows (windows.kde.org)
More information about the calligra-devel
mailing list