Review Request: Increase indent on a list item increases the displayed depth of the list i.e 1 becomes 1.1

[Gopalakrishna Bhat]

> On June 10, 2012, 6:25 p.m., C. Boemann wrote:
> > plugins/textshape/TextTool.cpp, line 1875
> > <http://git.reviewboard.kde.org/r/105198/diff/1-2/?file=66992#file66992line1875>
> >
> >     this line should be deleted

Will do


> On June 10, 2012, 6:25 p.m., C. Boemann wrote:
> > plugins/textshape/TextTool.cpp, line 1876
> > <http://git.reviewboard.kde.org/r/105198/diff/1-2/?file=66992#file66992line1876>
> >
> >     shouldn't you do the same for increase if >9

Yeah...Thanks for pointing out:)


> On June 10, 2012, 6:25 p.m., C. Boemann wrote:
> > plugins/textshape/TextTool.cpp, line 2252
> > <http://git.reviewboard.kde.org/r/105198/diff/1-2/?file=66992#file66992line2252>
> >
> >     space

will remove


> On June 10, 2012, 6:25 p.m., C. Boemann wrote:
> > libs/textlayout/ListItemsHelper.h, line 48
> > <http://git.reviewboard.kde.org/r/105198/diff/2/?file=67217#file67217line48>
> >
> >     wow it seems we have a lot of duplication here with libs/odf/KoOdfNumberDefinition  ::formattedNumber
> 
> C. Boemann wrote:
>     btw this wasn't meant to raise an issue for your patch - more like a general observation of something we should fix one day.

Yeah, I agree that there is a lot of duplications with KoOdfNumberDefinition. But that does not go well with the purpose of this patch(Thats the reason why I have excluded moving of ChangeListLevelCommand to kotext also)


- Gopalakrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105198/#review14586
-----------------------------------------------------------


On June 10, 2012, 6:08 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105198/
> -----------------------------------------------------------
> 
> (Updated June 10, 2012, 6:08 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch fixes bugs 260083 and 298063 by increasing the display level of the list when the list level is changed either by pressing tab or by using the "Increase Indent" button.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/commands/ChangeListCommand.cpp ea180fb 
>   libs/kotext/styles/KoListLevelProperties.cpp 12085e1 
>   libs/textlayout/ListItemsHelper.h c021b68 
>   libs/textlayout/ListItemsHelper.cpp d4e409c 
>   plugins/textshape/TextTool.cpp dff1fe1 
>   plugins/textshape/commands/ChangeListLevelCommand.cpp fdb5833 
> 
> Diff: http://git.reviewboard.kde.org/r/105198/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120611/06d6a653/attachment.htm>