Review Request: Fix saving of style child elements

Thorsten Zachmann t.zachmann at zagge.de
Mon Jun 11 07:49:25 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105212/
-----------------------------------------------------------

(Updated June 11, 2012, 6:49 a.m.)


Review request for Calligra.


Changes
-------

Add missing part of the patch.


Description
-------

When saving style child elements the child elements where always saved into the default property. However this is not correct as the output of Jos tests shows

[01:53:45]: kofficetests-odp (17s)
[01:53:45]: [kofficetests-odp] odf/odp/114096.odp
[01:53:45]: [odf/odp/114096.odp] INVALIDSTYLESXML: (unknown file):267: error: element "style:tab-stops" not allowed here; expected the element end-tag or element "style:background-image", "style:columns" or "text:list-style" MISSINGFILE: Object 1 INVALIDCONTENTXML: (unknown file):1061: error: element "style:tab-stops" not allowed here; expected the element end-tag or element "style:background-image", "style:columns" or "text:list-style" (unknown file):1081: error: element "style:tab-stops" not allowed here; expected the element end-tag or element "style:background-image", "style:columns" or "text:list-style" 

The problem is that the stye:tab-stops are added to the graphic properties but should be added to the paragraph properties. 

This patch adds the possibility to define the property the child elements should be added too.


Diffs (updated)
-----

  libs/kotext/styles/KoParagraphStyle.cpp dc02de3 
  libs/odf/KoGenStyle.h 346504d 
  libs/odf/KoGenStyle.cpp 2fef9b3 
  libs/odf/tests/TestKoGenStyles.cpp 062f3c9 

Diff: http://git.reviewboard.kde.org/r/105212/diff/


Testing
-------

Tested with the above document from calligratests and it works fine with it.


Thanks,

Thorsten Zachmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120611/3e7e2319/attachment.htm>


More information about the calligra-devel mailing list