Review Request: Increase indent on a list item increases the displayed depth of the list i.e 1 becomes 1.1

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105198/#review14586
-----------------------------------------------------------



plugins/textshape/TextTool.cpp
<http://git.reviewboard.kde.org/r/105198/#comment11518>

    this line should be deleted



plugins/textshape/TextTool.cpp
<http://git.reviewboard.kde.org/r/105198/#comment11517>

    shouldn't you do the same for increase if >9



plugins/textshape/TextTool.cpp
<http://git.reviewboard.kde.org/r/105198/#comment11516>

    space



libs/textlayout/ListItemsHelper.h
<http://git.reviewboard.kde.org/r/105198/#comment11519>

    wow it seems we have a lot of duplication here with libs/odf/KoOdfNumberDefinition  ::formattedNumber


- C. Boemann


On June 10, 2012, 6:08 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105198/
> -----------------------------------------------------------
> 
> (Updated June 10, 2012, 6:08 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch fixes bugs 260083 and 298063 by increasing the display level of the list when the list level is changed either by pressing tab or by using the "Increase Indent" button.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/commands/ChangeListCommand.cpp ea180fb 
>   libs/kotext/styles/KoListLevelProperties.cpp 12085e1 
>   libs/textlayout/ListItemsHelper.h c021b68 
>   libs/textlayout/ListItemsHelper.cpp d4e409c 
>   plugins/textshape/TextTool.cpp dff1fe1 
>   plugins/textshape/commands/ChangeListLevelCommand.cpp fdb5833 
> 
> Diff: http://git.reviewboard.kde.org/r/105198/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120610/5c3cfb50/attachment.htm>