Review Request: Slightly improve the option widget of the document background tool

[Friedrich W. H. Kossebau]

> On June 7, 2012, 2:59 p.m., C. Boemann wrote:
> > libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp, line 31
> > <http://git.reviewboard.kde.org/r/105153/diff/1/?file=66403#file66403line31>
> >
> >     Tool tips shouldn't have title case
> 
> Friedrich W. H. Kossebau wrote:
>     All tools which show their name/title in the tooltip use Title Case, so that is why I used that here.
>     
>     But then there is the problem that the tooltips are not consistent, some tools have the name set (e.g. "XY Tool"), some give the action (e.g. "Do xy"). Okay if I see to prepare a patch to align the tooltips of all the tools?
> 
> C. Boemann wrote:
>     I don't mind as long as you move towards all having descriptions rather than saying "Xxx Tool"
>     
>     But I think it should be discussed on a case by case basis, and not a single patch
> 
> Friedrich W. H. Kossebau wrote:
>     So to solve this blocker:
>     Change tooltip text to "Document background editing tool"?
>     Or rather "Edit document background"?
>     (still no idea how to know about page vs. slide without a view object there)
> 
> C. Boemann wrote:
>     How about "Document background"
>     
>     I actually have a private branch where I'm planing on making this tool a base only, and make the two real tools in stage and plan respectively. Furthermore I'm planing in stage to make it a "Slide Design" tool. Letting it swallow up the "layout docker" as an option widget.
> 
> Friedrich W. H. Kossebau wrote:
>     "Document background" is fine with me, having the "document" in is the important part for me :) (well, slide/page of course would be even better, but so far I found no trick).
>     
>     How soon will your private branch make it to master? For 2.5 already?
>     Otherwise I am now just waiting for your ship-it for this patch as an intermediate improvement for 2.5 :)
>
> 
> C. Boemann wrote:
>     it will definitely not make it for 2.5, and Thosten, the maintainer of Stage has already approved you patch, but i'll give you another ship-it, just for good measure

While Thorsten already approved, still you raised an issue, so I wanted to make sure the issue is solved for you :) And by the current answers I was not sure it really is (the issue item here still had a red dot, have now set to "Fixed"), needed an explicit "okay" to feel good with committing. Now have it, thanks :)


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105153/#review14472
-----------------------------------------------------------


On June 5, 2012, 4:30 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105153/
> -----------------------------------------------------------
> 
> (Updated June 5, 2012, 4:30 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> I think the option widget of the background tool would be improved with the attached patch, at least for me it would be more obvious what it does and how to use it. Most important are to state that this (only) about the background of the whole page/slide/document, not normal shapes, and to disable the "Set image..." button if the background of the master slide should be used.
> 
> Still not solved: mouse cursor always shows not-allowed cursor.
> 
> Commit message is:
>     Improve page background tool option widget
>     
>     * disable "Set image..." button if master page should be used
>     * add hint to use Stroke and Fill docker for color
>     * improve all texts slightly
>     * talk about slide or page depending of page type
> 
> 
> Diffs
> -----
> 
>   libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui ed0c271 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp 29fd22e 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp 92ac030 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.h 5888189 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp 332dfb8 
> 
> Diff: http://git.reviewboard.kde.org/r/105153/diff/
> 
> 
> Testing
> -------
> 
> Edited backgrounds of masterpage and normal pages both in Stage and Flow.
> 
> 
> Screenshots
> -----------
> 
> New tool options design, here for slides
>   http://git.reviewboard.kde.org/r/105153/s/595/
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120610/7f20488b/attachment.htm>