Review Request: Additional quick action buttons when mouse is over items, in Stage slides sorter.

[C. Boemann]

> On June 10, 2012, 4:12 a.m., Thorsten Zachmann wrote:
> > I could reproduce the blank slide show again but I don't know yet how to do that. Will investigate more.
> > 
> > I found a way that can make Calligra Stage crash. To reproduce:
> > o Have a slide show with more then one slide.
> > o Open Slide Sorter View
> > o Go to the last slide so that the icons are shown
> > o Press the delete button
> >   -> the buttons are still shown even if there is no more slide (should be fixed)
> > o Press the delete button again
> >   -> crash.
> 
> Paul Mendez wrote:
>     I am going to work in the second bug. Regarding the first I haven't found yet how it could happen. The code just set the activePage and then call the KPrView method to start the presentation. So, It's almost the same code of the normal view.

Sounds like something i may have solved in my canvas patch. Maybe you should postpone fixing until my patch is in master. (or at least try and apply and use my patch, to see)


- C.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103538/#review14564
-----------------------------------------------------------


On June 8, 2012, 6:32 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103538/
> -----------------------------------------------------------
> 
> (Updated June 8, 2012, 6:32 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Stage slides sorter has +/- buttons that appear when you move the mouse over an item to allow you select
> or deselect multiple items without using the keyboard.  This patch add extra actions (remove/duplicate slide and start slideshow from here)
> like gwenview, digikam quick actions.
> 
> 
> Diffs
> -----
> 
>   libs/kopageapp/KoPADocumentStructureDocker.h c49c429c6c0b8a11f0c024bce1accc2a7203fcff 
>   libs/kopageapp/KoPADocumentStructureDocker.cpp 7b31e5423db47955df6af9e2bb8ba3897895c61f 
>   libs/widgets/CMakeLists.txt 9c25397ca1c475a90b94f5c188fb0cdaf3f39373 
>   libs/widgets/KoContextBarButton.h PRE-CREATION 
>   libs/widgets/KoContextBarButton.cpp PRE-CREATION 
>   libs/widgets/KoSelectionManager.h a2db231db64982b836e67f3d3d40dca468aa0d6d 
>   libs/widgets/KoSelectionManager.cpp 23d0d88f951d701b82b43970a0f9d58043f96b52 
>   libs/widgets/KoSelectionToggle.h e83409fcded1cb2a7ef9fe0919a06308903aa9c0 
>   libs/widgets/KoSelectionToggle.cpp 6ad6866c857761aa2d2b0becd42db7e980e1e996 
>   libs/widgets/KoViewItemContextBar.h PRE-CREATION 
>   libs/widgets/KoViewItemContextBar.cpp PRE-CREATION 
>   stage/part/KPrSlidesSorterDocumentModel.cpp 74e7e7b98cec9cef720a81a030604ad7e98859bf 
>   stage/part/KPrViewModeSlidesSorter.h 705fd2a9cd6286ba12fe6836f622bf4ceda51367 
>   stage/part/KPrViewModeSlidesSorter.cpp 16d0bc051aed66a181b9f8479eca203fc14a6174 
> 
> Diff: http://git.reviewboard.kde.org/r/103538/diff/
> 
> 
> Testing
> -------
> 
> build and run
> 
> 
> Thanks,
> 
> Paul Mendez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120610/84449f55/attachment.htm>