Review Request: sync default line markers with LibreOffice 3.5 ones, i.e. add UML line ends

C. Boemann cbr at boemann.dk
Sat Jun 9 23:29:24 BST 2012



> On June 9, 2012, 5:27 p.m., C. Boemann wrote:
> > I've fixed the limiting bug, and although there is a small other bug (the lines show beneith the hole) I think it's good enough to be commited.
> 
> Friedrich W. H. Kossebau wrote:
>     Great, thanks!
>     Will check what the latest state is with LO 3.5/3.6 and what line markers they ship, then update if there are news, or just commit, if there are no changes.
>
> 
> Friedrich W. H. Kossebau wrote:
>     Is your fix also going to be backported to 2.4? if it is, okay to also backport to 2.4, once the fix is in there?

I was not going to packport my fix but I could. However I don't think the new types which is a feature should be backported. 


- C.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104560/#review14557
-----------------------------------------------------------


On April 13, 2012, 5:22 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104560/
> -----------------------------------------------------------
> 
> (Updated April 13, 2012, 5:22 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> LibreOffice 3.5 has some new markers, similar to UML line ends.
> Cmp. http://cgit.freedesktop.org/libreoffice/core/commit/?id=7661f0943d6286b7e7075c5f2e172f23d53ea47d
> 
> Only problem is that other than a few weeks ago when I played with these the first time the markers with holes in it are now not rendered correctly in Calligra :(
> No idea why yet, could not see any suspicious commit. This rendering bug is filed as https://bugs.kde.org/show_bug.cgi?id=297981
> 
> Once that is fixed this patch should be merged.
> Or before even, to have the bug in front of our face? After all people might create files with such markers already in e.g. LO 3.5, so a fix is urgent, also for 2.4 :)
> 
> 
> Diffs
> -----
> 
>   libs/flake/styles/markers.xml 9d131fc 
> 
> Diff: http://git.reviewboard.kde.org/r/104560/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120609/3028fb2e/attachment.htm>


More information about the calligra-devel mailing list