Review Request: Rewrote all list-items using newly defined roles Fixed visibility of 3rd column without using event filter

[Adam Pigg]

> On June 9, 2012, 3:52 p.m., Jarosław Staniek wrote:
> >

To try, use branch kexi-q3port-piggz


> On June 9, 2012, 3:52 p.m., Jarosław Staniek wrote:
> > kexi/formeditor/kexiactionselectiondialog.cpp, line 318
> > <http://git.reviewboard.kde.org/r/105187/diff/2/?file=66995#file66995line318>
> >
> >     Don't we want to expand this item?

Not any more, lists are flat now dues to using QListWidget


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105187/#review14551
-----------------------------------------------------------


On June 9, 2012, 1:18 p.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105187/
> -----------------------------------------------------------
> 
> (Updated June 9, 2012, 1:18 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> Rewrote all list-items using newly defined roles Fixed visibility of 3rd column without using event filter
> 
> 
> Remove unused sorting code
> 
> 
> Allow to not set the project model to not searchable
> 
> This prevents multiple models being added when not required.
> 
> Add back the current form action
> 
> 
> Action now created properly and wors on form buttons
> 
> Also fixed crash in project navigator
> 
> Use the part class correctly
> 
> 
> Inital port away from Q3/K3
> 
> Not fully functioning yet, but compiles and runs
> Unused files removed
> 
> 
> Diffs
> -----
> 
>   kexi/formeditor/kexiactionselectiondialog.h 7e2d63befc4c4f8ff160bf5ab897024f63f6f590 
>   kexi/formeditor/kexiactionselectiondialog.cpp 15e59d6effe535bfe433d7e274c9e6b49ec79744 
>   kexi/formeditor/kexiactionselectiondialog_p.h 8e2a1fe6820b1e41267ef50fb01aa47d70073cf1 
>   kexi/widget/CMakeLists.txt c4106a3be823a0e54d21ecf5a2bcf24bb8ab246e 
>   kexi/widget/navigator/KexiProjectListView.h 755579bc5c57f187829f7ab3c6c49e204299524e 
>   kexi/widget/navigator/KexiProjectListView.cpp 127ac941e3958c6540593acceab6abd9928bec82 
>   kexi/widget/navigator/KexiProjectListViewItem.h 88a515465ea1c0ed62d23e3ce39bff00a467af19 
>   kexi/widget/navigator/KexiProjectListViewItem.cpp 540aaeec5082bcf2952243ae4a7367a971a0b4a8 
>   kexi/widget/navigator/KexiProjectListView_p.h 9d7b678589937b398d18ef92be676ae382b7210d 
>   kexi/widget/navigator/KexiProjectNavigator.h 009ff78d4d3c9417aa90247da48601406ca06149 
>   kexi/widget/navigator/KexiProjectNavigator.cpp 095422fb149ea76a2c566d66a3412e92c855bddf 
> 
> Diff: http://git.reviewboard.kde.org/r/105187/diff/
> 
> 
> Testing
> -------
> 
> Compiles Ok
> 
> Dialog displays Ok except 3rd column is initially the wrong size (fixes welcome)
> 
> Tested nearly all combinations of action, and that the save/load Ok, and that the actions still work in data mode.
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120609/89af0bc0/attachment.htm>