Review Request: Adds a page/slide navigator control for the statusbar, used in Stage & Flow

Friedrich W. H. Kossebau kossebau at kde.org
Sat Jun 9 13:25:43 BST 2012


Am Samstag, 9. Juni 2012, 06:06:02 schrieben Sie:
> Hello Friedrich,
> 
> > > One thing I noticed which is not due to your code but only visible when
> > > your code is there is that if you enter the first/last page in the
> > > widget
> > > the actions do not get enabled/disabled and therefore it shows the old
> > > state of the actions, e.g. when entering the last page the next and last
> > > action should be disabled and the first/previous should be enabled.
> > 
> > Found at least a workaround, or perhaps even the right-thing-to-do here,
> > setting the active page via the proxyobject, like
> > KoPAView::navigatePage(...) does.
> > 
> > Okay to commit?
> 
> Looks good please commit.

Thanks, done.

Cheers
Friedrich



More information about the calligra-devel mailing list