Review Request: Implemented KexiDBDatePicker

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105179/#review14520
-----------------------------------------------------------

Ship it!


Good, only minor suggestions, please fix and commit :)


kexi/plugins/forms/widgets/kexidbdatepicker.cpp
<http://git.reviewboard.kde.org/r/105179/#comment11477>

    not needed



kexi/plugins/forms/widgets/kexidbdatepicker.cpp
<http://git.reviewboard.kde.org/r/105179/#comment11476>

    see below



kexi/plugins/forms/widgets/kexidbdatepicker.cpp
<http://git.reviewboard.kde.org/r/105179/#comment11475>

    This would be enough:
    return lineEdit && lineEdit->hasFocus() && lineEdit->cursorPosition() == lineEdit->text().length();


- Jarosław Staniek


On June 8, 2012, 5:13 p.m., Oleg Kukharchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105179/
> -----------------------------------------------------------
> 
> (Updated June 8, 2012, 5:13 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> Kexi Froms get new widget
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/forms/CMakeLists.txt 588fae903234da1e41aac1020e9ada01eeb06d08 
>   kexi/plugins/forms/kexidbfactory.cpp 4d8412372d85c74347118da5f4fbda544f413b25 
>   kexi/plugins/forms/kexiformmanager.cpp 521dfb62e303fb594daa33d0c58a7b17cc62cd5e 
>   kexi/plugins/forms/widgets/kexidbdatepicker.h PRE-CREATION 
>   kexi/plugins/forms/widgets/kexidbdatepicker.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105179/diff/
> 
> 
> Testing
> -------
> 
> tested on current master branch
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120608/2a187bd6/attachment.htm>