Review Request: Adds a page/slide navigator control for the statusbar, used in Stage & Flow

Friedrich W. H. Kossebau kossebau at kde.org
Fri Jun 8 20:15:18 BST 2012


Am Freitag, 8. Juni 2012, 05:23:16 schrieb Thorsten Zachmann:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105180/#review14507
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Please commit after fixing the details I noticied. If I miss someting on the
> inline stuff lets discuss it before committing.
> 
> One thing I noticed which is not due to your code but only visible when your
> code is there is that if you enter the first/last page in the widget the
> actions do not get enabled/disabled and therefore it shows the old state of
> the actions, e.g. when entering the last page the next and last action
> should be disabled and the first/previous should be enabled.

Found at least a workaround, or perhaps even the right-thing-to-do here, 
setting the active page via the proxyobject, like KoPAView::navigatePage(...) 
does.

Okay to commit?

Cheers
Friedrich
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixPageNavigatorButtonsUpdate.patch
Type: text/x-patch
Size: 507 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120608/b26c2a66/attachment.bin>


More information about the calligra-devel mailing list