Review Request: GSoC: Add support of Anim:Formula tag in Stage
Paul Mendez
paulestebanms at gmail.com
Fri Jun 8 09:07:01 BST 2012
> On June 8, 2012, 7:13 a.m., Thorsten Zachmann wrote:
> > stage/part/animations/strategy/KPrSmilValues.cpp, line 131
> > <http://git.reviewboard.kde.org/r/105030/diff/4/?file=66752#file66752line131>
> >
> > The brackets are not needed please remove.
Thanks, I fixed the brackets issue.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105030/#review14508
-----------------------------------------------------------
On June 8, 2012, 8:04 a.m., Paul Mendez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105030/
> -----------------------------------------------------------
>
> (Updated June 8, 2012, 8:04 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Add support for Anim:Formula tag in Stage. (That key is part of ODF animations specification).
>
> Note: animations tested don't run as smooth as in LibreOffice because KeySplines tag is not implemented.
>
>
> Diffs
> -----
>
> stage/part/CMakeLists.txt 3c7916ef7496af21e65d9a5441d5cb924829c347
> stage/part/animations/KPrAnimate.cpp dddd1fa401d596e7e23688f950428cd0ea76b639
> stage/part/animations/strategy/KPrFormulaParser.h PRE-CREATION
> stage/part/animations/strategy/KPrFormulaParser.cpp PRE-CREATION
> stage/part/animations/strategy/KPrSmilValues.h 163d78b830a151ce150192000890a395f9e273dd
> stage/part/animations/strategy/KPrSmilValues.cpp 3faafc4eb1c8783224f9f32c38106407cc219096
> stage/part/animations/strategy/KPrValueParser.h 8f3c6ebcdf7ae9f5d938d97d518f21977b572940
> stage/part/animations/strategy/KPrValueParser.cpp ca7fac767142e64b9711ccf835efcb9a4c242e36
>
> Diff: http://git.reviewboard.kde.org/r/105030/diff/
>
>
> Testing
> -------
>
> Test some animations of documents created in Libre Office (One test document is also uploaded)
>
>
> Thanks,
>
> Paul Mendez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120608/b7dcea18/attachment.htm>
More information about the calligra-devel
mailing list