Review Request: turn the tooltips of all tools consistently into "Does something" style

Fri Jun 8 02:42:41 BST 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105183/#review14503
-----------------------------------------------------------

I'm sorry, but I think I also said it should be done individually and with discussions. (I so wish you would join us on irc)

A mass rename like this following a textbook pattern is just bad usability. Every text should be thought out on it's own.

Another thing to consider is that the tool tips are also used as titles in Words and Sheets, which means they should be short and concise and preferably start with the important word.

For example "Animation Tool" should just be "Animation" not some long text that starts with "Edit xxx" like all the other tool tips

In some places I give my suggestion of what I think it should be instead.

More importantly I veto a lot as mentioned below, and I suspect a lot of the krita tips will be veto'ed too.

I'm sorry if I was not clear enough in my reply in that other request, leading you to do this.

libs/flake/tools/KoCreatePathToolFactory.cpp
<http://git.reviewboard.kde.org/r/105183/#comment11446>

    Draw curve line

libs/flake/tools/KoCreateShapesToolFactory.cpp
<http://git.reviewboard.kde.org/r/105183/#comment11447>

    Insert shape

plugins/defaultTools/defaulttool/DefaultToolFactory.cpp
<http://git.reviewboard.kde.org/r/105183/#comment11448>

    No

plugins/staging/templateshape/TemplateToolFactory.cpp
<http://git.reviewboard.kde.org/r/105183/#comment11449>

    This just shows how bad it is to do this kind of mass renaming following a pattern

plugins/textshape/ReferencesToolFactory.cpp
<http://git.reviewboard.kde.org/r/105183/#comment11450>

    No

plugins/textshape/ReviewToolFactory.cpp
<http://git.reviewboard.kde.org/r/105183/#comment11451>

    No

plugins/textshape/TextToolFactory.cpp
<http://git.reviewboard.kde.org/r/105183/#comment11452>

    No

sheets/part/CellToolFactory.cpp
<http://git.reviewboard.kde.org/r/105183/#comment11453>

    No

stage/part/tools/animationtool/KPrAnimationToolFactory.cpp
<http://git.reviewboard.kde.org/r/105183/#comment11454>

    No
    I've just changed it to "Animation" anyway

words/part/pagetool/KWPageToolFactory.cpp
<http://git.reviewboard.kde.org/r/105183/#comment11455>

    No

- C. Boemann

On June 8, 2012, 1 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105183/
> -----------------------------------------------------------
> 
> (Updated June 8, 2012, 1 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> As follow-up of https://git.reviewboard.kde.org/r/105153/ (Slightly improve the option widget of the document background tool) a proposal how to change all tooltips.
> 
> Should I better split this big patch into small ones per app/component?
> 
> 
> Diffs
> -----
> 
>   braindump/plugins/stateshape/StateToolFactory.cpp 2c8e747 
>   braindump/plugins/webshape/WebToolFactory.cpp 9983b7d 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyToolFactory.cpp 0342e6e 
>   karbon/plugins/tools/KarbonGradientToolFactory.cpp 8f922e4 
>   karbon/plugins/tools/KarbonPatternToolFactory.cpp dd6dad6 
>   karbon/plugins/tools/KarbonPencilToolFactory.cpp c1eb00a 
>   karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsToolFactory.cpp 089fc36 
>   kexi/plugins/shapes/relationdesign/kexirelationdesigntoolfactory.cpp 4cc87bf 
>   krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.h 12f0335 
>   krita/plugins/tools/defaulttools/kis_tool_fill.h 8ec6bb1 
>   krita/plugins/tools/defaulttools/kis_tool_gradient.h 8e24d33 
>   krita/plugins/tools/defaulttools/kis_tool_path.h 6900fb7 
>   krita/plugins/tools/selectiontools/kis_tool_select_magnetic.h d69c6b8 
>   krita/plugins/tools/selectiontools/kis_tool_select_path.h 11f3e0f 
>   krita/plugins/tools/tool_polygon/kis_tool_polygon.h d0b8713 
>   krita/plugins/tools/tool_polyline/kis_tool_polyline.h 5df8500 
>   krita/plugins/tools/tool_text/kis_tool_text.h ba149d3 
>   krita/sdk/templates/tool/kis_tool_APPNAMELC.h caa1800 
>   libs/flake/tools/KoCreatePathToolFactory.cpp 9d25fa5 
>   libs/flake/tools/KoCreateShapesToolFactory.cpp 047c5a8 
>   libs/flake/tools/KoPathToolFactory.cpp 13359b9 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp 92ac030 
>   plugins/artistictextshape/ArtisticTextToolFactory.cpp c4a9918 
>   plugins/chartshape/ChartToolFactory.cpp 9b67999 
>   plugins/commentshape/CommentToolFactory.cpp 9198704 
>   plugins/defaultTools/connectionTool/ConnectionToolFactory.cpp 6a04221 
>   plugins/defaultTools/defaulttool/DefaultToolFactory.cpp a0e97cd 
>   plugins/formulashape/KoFormulaToolFactory.cpp d839b87 
>   plugins/musicshape/MusicToolFactory.cpp 39d176b 
>   plugins/musicshape/SimpleEntryToolFactory.cpp a68e114 
>   plugins/pictureshape/PictureToolFactory.cpp cc47406 
>   plugins/staging/templateshape/TemplateToolFactory.cpp ebf0e47 
>   plugins/textshape/ReferencesToolFactory.cpp d5f999a 
>   plugins/textshape/ReviewToolFactory.cpp eb20719 
>   plugins/textshape/TextToolFactory.cpp 4c0d3a3 
>   plugins/vectorshape/VectorToolFactory.cpp 04212c6 
>   sheets/part/CellToolFactory.cpp 4573c10 
>   sheets/shape/TableToolFactory.cpp 5eb228c 
>   stage/part/tools/KPrPlaceholderToolFactory.cpp a13d8ad 
>   stage/part/tools/animationtool/KPrAnimationToolFactory.cpp c743099 
>   words/part/pagetool/KWPageToolFactory.cpp c0680ab 
> 
> Diff: http://git.reviewboard.kde.org/r/105183/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120608/6dbeaf1b/attachment.htm>