Review Request: Implemented KexiDBDatePicker

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105179/#review14493
-----------------------------------------------------------

Ship it!


Cool, please commit (after fixing the one issue and answering my questions)!


kexi/plugins/forms/widgets/kexidbdatepicker.cpp
<http://git.reviewboard.kde.org/r/105179/#comment11440>

    Please put types in the same line - we used to break this rule but we no longer want to do that :)



kexi/plugins/forms/widgets/kexidbdatepicker.cpp
<http://git.reviewboard.kde.org/r/105179/#comment11442>

    Checking .isValid() could be even better (null date is also invalid) if the picker cannot present invalid dates.



kexi/plugins/forms/widgets/kexidbdatepicker.cpp
<http://git.reviewboard.kde.org/r/105179/#comment11443>

    Checking .isValid() could be even better (null date is also invalid) if the picker cannot present invalid dates.



kexi/plugins/forms/widgets/kexidbdatepicker.cpp
<http://git.reviewboard.kde.org/r/105179/#comment11441>

    Don't we need just to call QWidget::hasFocus() when we need this info? Why we want to store and maintain this flag in extra place?


- Jarosław Staniek


On June 7, 2012, 6:04 p.m., Oleg Kukharchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105179/
> -----------------------------------------------------------
> 
> (Updated June 7, 2012, 6:04 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> Kexi Froms get new widget
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/forms/CMakeLists.txt 588fae903234da1e41aac1020e9ada01eeb06d08 
>   kexi/plugins/forms/kexidbfactory.cpp 4d8412372d85c74347118da5f4fbda544f413b25 
>   kexi/plugins/forms/kexiformmanager.cpp 521dfb62e303fb594daa33d0c58a7b17cc62cd5e 
>   kexi/plugins/forms/widgets/kexidbdatepicker.h PRE-CREATION 
>   kexi/plugins/forms/widgets/kexidbdatepicker.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105179/diff/
> 
> 
> Testing
> -------
> 
> tested on current master branch
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120607/381e91d4/attachment.htm>