Review Request: Use KoModeBox in Sheets
Marijn Kruisselbrink
mkruisselbrink at kde.org
Thu Jun 7 21:08:35 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105175/#review14491
-----------------------------------------------------------
Ship it!
Ship It!
- Marijn Kruisselbrink
On June 7, 2012, 3:50 p.m., C. Boemann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105175/
> -----------------------------------------------------------
>
> (Updated June 7, 2012, 3:50 p.m.)
>
>
> Review request for Calligra and Marijn Kruisselbrink.
>
>
> Description
> -------
>
> Sheets is not a canvas base application, so just like Words the metaphor of a toolbox is wrong.
>
> This patch uses the same ui that Words has, increasing the commonality between the productivity application.
>
>
> Diffs
> -----
>
> libs/main/KoModeBox.cpp 24ca271
> sheets/part/CellToolFactory.cpp fd3df68
> sheets/part/View.cpp 77667ba
>
> Diff: http://git.reviewboard.kde.org/r/105175/diff/
>
>
> Testing
> -------
>
> Nothing special, apart from having been used in Words since 2.4. well, naturally I tested that it works in Sheets
>
>
> Thanks,
>
> C. Boemann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120607/bb36d9ab/attachment.htm>
More information about the calligra-devel
mailing list