Review Request: Add support for footnote's continuation

C. Boemann cbr at boemann.dk
Thu Jun 7 20:06:22 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104043/#review14488
-----------------------------------------------------------

Ship it!


just a few small things to fix


libs/textlayout/KoTextLayoutArea.cpp
<http://git.reviewboard.kde.org/r/104043/#comment11434>

    footnotes



libs/textlayout/KoTextLayoutArea.cpp
<http://git.reviewboard.kde.org/r/104043/#comment11433>

    hmm this comment should not be there



libs/textlayout/KoTextLayoutNoteArea.cpp
<http://git.reviewboard.kde.org/r/104043/#comment11435>

    let's not keep this line 



libs/textlayout/KoTextLayoutObstruction.cpp
<http://git.reviewboard.kde.org/r/104043/#comment11436>

    please undo these two changes


- C. Boemann


On June 7, 2012, 6:54 p.m., Brijesh Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104043/
> -----------------------------------------------------------
> 
> (Updated June 7, 2012, 6:54 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch adds a feature, continuation of footnotes on next page when there's no space to fit on the same page, as part of footnote's configuration.
> 
> 
> Diffs
> -----
> 
>   libs/odf/KoOdfNotesConfiguration.cpp 7a2ca81 
>   libs/textlayout/KoTextDocumentLayout.h a8efa0b 
>   libs/textlayout/KoTextDocumentLayout.cpp 17192cb 
>   libs/textlayout/KoTextLayoutArea.h e588d82 
>   libs/textlayout/KoTextLayoutArea.cpp 7fe8870 
>   libs/textlayout/KoTextLayoutEndNotesArea.cpp 4a1b44d 
>   libs/textlayout/KoTextLayoutNoteArea.h fabaef8 
>   libs/textlayout/KoTextLayoutNoteArea.cpp 3d882d0 
>   libs/textlayout/KoTextLayoutObstruction.h f3e3e3c 
>   libs/textlayout/KoTextLayoutObstruction.cpp db4e34e 
>   libs/textlayout/KoTextLayoutRootArea.cpp 23238b0 
>   plugins/textshape/ReferencesTool.cpp 68fe39a 
>   plugins/textshape/dialogs/NotesConfigurationDialog.cpp 4e6f6d3 
> 
> Diff: http://git.reviewboard.kde.org/r/104043/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brijesh Patel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120607/9759e9ea/attachment.htm>


More information about the calligra-devel mailing list