Review Request: PDF export: Use view to get page layout

C. Boemann cbr at boemann.dk
Thu Jun 7 16:08:00 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105168/#review14473
-----------------------------------------------------------

Ship it!


except for two coding style nitpicks


libs/main/KoView.h
<http://git.reviewboard.kde.org/r/105168/#comment11427>

    please remove spaces



libs/main/KoView.h
<http://git.reviewboard.kde.org/r/105168/#comment11428>

    please remove spaces


- C. Boemann


On June 7, 2012, 9:28 a.m., Dag Andersen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105168/
> -----------------------------------------------------------
> 
> (Updated June 7, 2012, 9:28 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Currently page layout is fetched directly from the document.
> View-centric apps like plan needs to get page layout dependent on the current view.
> This patch adds a virtual pageLayout() method to KoView that by default gets page layout from the document.
> 
> 
> This addresses bug 301326.
>     http://bugs.kde.org/show_bug.cgi?id=301326
> 
> 
> Diffs
> -----
> 
>   libs/main/KoMainWindow.cpp b4c3df8 
>   libs/main/KoView.h 203e947 
>   libs/main/KoView.cpp a093d8e 
> 
> Diff: http://git.reviewboard.kde.org/r/105168/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dag Andersen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120607/cf1a3ec4/attachment.htm>


More information about the calligra-devel mailing list