Review Request: make UI texts for exporting Kexi reports more consistent (and solve Kexi i18n TODOs for 2.5)

[Adam Pigg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105164/#review14451
-----------------------------------------------------------



kexi/plugins/reports/kexireportview.cpp
<http://git.reviewboard.kde.org/r/105164/#comment11403>

    See comment 1



kexi/plugins/reports/kexireportview.cpp
<http://git.reviewboard.kde.org/r/105164/#comment11402>

    If i recall, there is a reason for the " " .. i think in maemo, the icon didnt display propery without it


- Adam Pigg


On June 6, 2012, 4:37 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105164/
> -----------------------------------------------------------
> 
> (Updated June 6, 2012, 4:37 p.m.)
> 
> 
> Review request for Calligra and Adam Pigg.
> 
> 
> Description
> -------
> 
> See summary. In detail the patch does:
>     * use "Export" instead of "Save" everywhere
>     * give hint to used file formats in tooltip/whatsthis
>     * use same phrases with all formats
> 
> Like that solution?
> 
> I was also tempted to turn the export buttons into a dropdown menu, to make the toolbar less cluttered. No idea if that would clash with any Kexi UI guidelines...
> 
> 
> Diffs
> -----
> 
>   kexi/doc/dev/CHANGELOG-Kexi-js f4c055c 
>   kexi/plugins/reports/kexireportview.h d119a86 
>   kexi/plugins/reports/kexireportview.cpp 0482984 
> 
> Diff: http://git.reviewboard.kde.org/r/105164/diff/
> 
> 
> Testing
> -------
> 
> Exported to all three formats, incl. overwriting files or not.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120606/c02e4320/attachment.htm>