Review Request: Kexi MainWindow fullscreen feature.

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105105/#review14286
-----------------------------------------------------------



kexi/core/kexistartupdata.h
<http://git.reviewboard.kde.org/r/105105/#comment11305>

    type is -> if



kexi/core/kexistartupdata.h
<http://git.reviewboard.kde.org/r/105105/#comment11304>

    -> forcedFullScreen()



kexi/main/KexiMainWindow.cpp
<http://git.reviewboard.kde.org/r/105105/#comment11306>

    We want this action in global collection too, so this is missing:
    ac->addAction("full_screen", d->action_window_fullscreen);



kexi/main/KexiMainWindow.cpp
<http://git.reviewboard.kde.org/r/105105/#comment11401>

    Let's do not change visibility of navigator and propeditor docks. In design mode it is not convenient. 
    
    The logics is also hard to understand; e.g. scenario: 1. open table in design view (prop editor shows), 2. enter fullscreen (prop editor hides), 3. go to data mode (prop editor still hidden), 4. exit full screen (prop editor shows despite of having data view).
    


Please fix the issues, otherwise great feature, we want them for 2.5 beta (before June 15th)...

- Jarosław Staniek


On May 29, 2012, 11:53 p.m., Dimitrios Tanis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105105/
> -----------------------------------------------------------
> 
> (Updated May 29, 2012, 11:53 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> Kexi MainWindow fullscreen feature.
> 
> Kexi fullscreen is implemented for Mainwindow, serving better
> manipulation in small factor screens (eg netbooks). Feature is
> accessible both using shortcuts and at launch from console.
> 
> CCBUG: 298880
> 
> PS. It is invoked via F11 (firefox style) or Standard Shortcut ctrl+shift+f
> 
> 
> Diffs
> -----
> 
>   kexi/main/startup/KexiStartup.cpp f2e8d32c40224aed7f17b9d51309d4faa9840707 
>   kexi/main/KexiMainWindow_p.h db5c6448f49c67645c45e3f75590a2a2372a5180 
>   kexi/main/KexiMainWindow.h 3e4aeff500112ea425e1c60ec45e47b2f5be5109 
>   kexi/main/KexiMainWindow.cpp 3bef113b21611e24f1d26114a6a190d3677c42f5 
>   kexi/core/kexistartupdata.cpp 60d0d637b2fd6fe7b585bd95f4767081d7167def 
>   kexi/core/kexistartupdata.h 7b43fdc4b4d6291f6ada3af7649883fe8d84349f 
>   kexi/core/kexicmdlineargs.h b7579b9c9fb589acfad3eada50e2438a8aa5800d 
> 
> Diff: http://git.reviewboard.kde.org/r/105105/diff/
> 
> 
> Testing
> -------
> 
> Works for KexiMainWindow
> 
> 
> Screenshots
> -----------
> 
> Kexi Fullscreen Feature
>   http://git.reviewboard.kde.org/r/105105/s/577/
> 
> 
> Thanks,
> 
> Dimitrios Tanis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120606/cfa3d6de/attachment.htm>