Review Request: Slightly improve the option widget of the document background tool

C. Boemann cbr at boemann.dk
Tue Jun 5 17:51:44 BST 2012



> On June 5, 2012, 4:38 p.m., C. Boemann wrote:
> > libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp, line 61
> > <http://git.reviewboard.kde.org/r/105153/diff/1/?file=66405#file66405line61>
> >
> >     uhm clicked and stateChange works rather differently.
> >     are you sure about this
> 
> Friedrich W. H. Kossebau wrote:
>     AFAIK the stateChanged signal is also only triggered on user interaction, same with the clicked signal. Only the toggled signal is emitted what-ever the reason is. So no problem here IMHO.
>     Or what do you mean?

ok nevermind


- C.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105153/#review14424
-----------------------------------------------------------


On June 5, 2012, 4:30 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105153/
> -----------------------------------------------------------
> 
> (Updated June 5, 2012, 4:30 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> I think the option widget of the background tool would be improved with the attached patch, at least for me it would be more obvious what it does and how to use it. Most important are to state that this (only) about the background of the whole page/slide/document, not normal shapes, and to disable the "Set image..." button if the background of the master slide should be used.
> 
> Still not solved: mouse cursor always shows not-allowed cursor.
> 
> Commit message is:
>     Improve page background tool option widget
>     
>     * disable "Set image..." button if master page should be used
>     * add hint to use Stroke and Fill docker for color
>     * improve all texts slightly
>     * talk about slide or page depending of page type
> 
> 
> Diffs
> -----
> 
>   libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui ed0c271 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp 29fd22e 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp 92ac030 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.h 5888189 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp 332dfb8 
> 
> Diff: http://git.reviewboard.kde.org/r/105153/diff/
> 
> 
> Testing
> -------
> 
> Edited backgrounds of masterpage and normal pages both in Stage and Flow.
> 
> 
> Screenshots
> -----------
> 
> New tool options design, here for slides
>   http://git.reviewboard.kde.org/r/105153/s/595/
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120605/14ef92f2/attachment.htm>


More information about the calligra-devel mailing list