Review Request: Add support for table templates

Gopalakrishna Bhat gopalakbhat at gmail.com
Sat Jul 28 17:08:26 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105771/
-----------------------------------------------------------

(Updated July 28, 2012, 4:08 p.m.)


Review request for Calligra.


Changes
-------

Updated diff to add missing new files KoTextTableTemplate.*


Description
-------

Add support for templates in table. 

LO saves a invalid ODF attribute text:style-name for table:table-template element, so created a workaround for that while loading. Do we need to create this workaround while saving also(doing so will create an invalid ODF)?


This addresses bug 277764.
    http://bugs.kde.org/show_bug.cgi?id=277764


Diffs (updated)
-----

  libs/flake/KoOdfWorkaround.h ffeb463 
  libs/flake/KoOdfWorkaround.cpp d6aff39 
  libs/kotext/CMakeLists.txt 7146ffa 
  libs/kotext/KoTextTableTemplate.h PRE-CREATION 
  libs/kotext/KoTextTableTemplate.cpp PRE-CREATION 
  libs/kotext/opendocument/KoTextLoader.cpp 1ea701c 
  libs/kotext/opendocument/KoTextSharedLoadingData.h dd10b19 
  libs/kotext/opendocument/KoTextSharedLoadingData.cpp 84df888 
  libs/kotext/opendocument/KoTextSharedSavingData.h 1d4f301 
  libs/kotext/opendocument/KoTextSharedSavingData.cpp ec6b368 
  libs/kotext/opendocument/KoTextWriter_p.cpp 1b3ae9d 
  libs/kotext/styles/KoStyleManager.h d787bb6 
  libs/kotext/styles/KoStyleManager.cpp b207f40 
  libs/kotext/styles/KoTableCellStyle.h 72d8cc7 
  libs/kotext/styles/KoTableCellStyle.cpp 3104306 
  libs/kotext/styles/KoTableStyle.h 67bd704 
  libs/odf/CMakeLists.txt ce45ade 
  libs/odf/KoGenStyles.cpp 1dc2f40 
  libs/odf/KoOdfStylesReader.h 9e77434 
  libs/odf/KoOdfStylesReader.cpp 3da03b9 
  libs/textlayout/KoTextDocumentLayout.h 5715b43 
  libs/textlayout/KoTextDocumentLayout.cpp 7621652 
  libs/textlayout/KoTextLayoutTableArea.cpp 45e19c9 
  plugins/textshape/TextShape.h dc513c9 
  plugins/textshape/TextShape.cpp f707e4b 
  plugins/textshape/TextShapeFactory.cpp 4e6d817 

Diff: http://git.reviewboard.kde.org/r/105771/diff/


Testing
-------


Thanks,

Gopalakrishna Bhat

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120728/0eedd2c5/attachment.htm>


More information about the calligra-devel mailing list