Review Request: fix for losing style:column and style:column-gap on round-trip through Calligra

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105736/
-----------------------------------------------------------

Review request for Calligra and C. Boemann.


Description
-------

Current draft of code to at least keep the data read from style:column and style:column-gap elements and also write it again.

To make it complete I also changed KoPagePreviewWidget and KWFrameLayout to use the columndata if present, so the layout is not messed and results in broken looking display.
I have no real idea about the KoSectionStyle code, as I could not test it. And I also have not yet done any unit tests.
But feedback is already welcome.

Candidate for backport to 2.5, due to the otherwise data loss.


Diffs
-----

  libs/kotext/styles/KoSectionStyle.h 7d06a9e 
  libs/kotext/styles/KoSectionStyle.cpp 294a85a 
  libs/odf/CMakeLists.txt ce45ade 
  libs/odf/KoColumns.h 6bd7267 
  libs/odf/KoColumns.cpp PRE-CREATION 
  libs/widgets/KoPagePreviewWidget.cpp 8fe2c68 
  words/part/KWDocument.cpp 014e106 
  words/part/KWPageStyle.cpp ebc9103 
  words/part/KWRootAreaProvider.cpp d4a0a9b 
  words/part/dialogs/KWDocumentColumns.cpp f0ab3cf 
  words/part/frames/KWFrameLayout.cpp a99cfb8 
  words/part/tests/TestFrameLayout.cpp 312e6ce 
  words/part/tests/TestPageCommands.cpp 4f1f46f 

Diff: http://git.reviewboard.kde.org/r/105736/diff/


Testing
-------

Roundtrips of documents between LO 3.5 and Calligra master with this patch.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120726/2786bea5/attachment.htm>