Review Request: Fix for text input in Krita text shapes

[Arjen Hiemstra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105625/#review16302
-----------------------------------------------------------



krita/ui/input/kis_input_manager.cpp
<http://git.reviewboard.kde.org/r/105625/#comment12802>

    Since you're checking both the other methods, there is no real need to check here as well.



krita/ui/input/kis_input_manager.cpp
<http://git.reviewboard.kde.org/r/105625/#comment12801>

    Might want to remove the debug here.



krita/ui/input/kis_input_manager.cpp
<http://git.reviewboard.kde.org/r/105625/#comment12800>

    The setter here is a little superfluous considering you're changing a private variable anyway.


- Arjen Hiemstra


On July 19, 2012, 6:55 p.m., Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105625/
> -----------------------------------------------------------
> 
> (Updated July 19, 2012, 6:55 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> The patch fixes a problem with text input as reported in bug 303635. The problem is that the input manager still matches new shortcuts when the user wants to write a text. With the change the current action is fixed until the users switches the tool.
> 
> 
> This addresses bug 303635.
>     http://bugs.kde.org/show_bug.cgi?id=303635
> 
> 
> Diffs
> -----
> 
>   krita/ui/input/kis_input_manager.h 44b7b37 
>   krita/ui/input/kis_input_manager.cpp 63ef640 
>   krita/ui/input/kis_tool_invocation_action.cpp 7757d51 
> 
> Diff: http://git.reviewboard.kde.org/r/105625/diff/
> 
> 
> Testing
> -------
> 
> Tested with text shape, input works.
> 
> 
> Thanks,
> 
> Sven Langkamp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120724/e5f372ed/attachment.htm>