Review Request: fix missing icons "edit-duplicate" & "edit-merge" by using "edit-copy" & no icon (Krita context menu on layers)

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105692/#review16300
-----------------------------------------------------------


This review has been submitted with commit 8dd59d9d6bcab99a8d6b132df65c3ed4d30970c5 by Friedrich W. H. Kossebau to branch calligra/2.5.

- Commit Hook


On July 23, 2012, 3:51 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105692/
> -----------------------------------------------------------
> 
> (Updated July 23, 2012, 3:51 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Description
> -------
> 
> In the "Layers" docker of Krita, the context menu of layers tries to use the icons "edit-duplicate" and "edit-merge", but they do not exist.
> 
> Patch fixes this:
> * by using "edit-copy" for the "Duplicate Layer or Mask" action, like it is also done in the toolbar at the bottom of the docker for the very same action (and by KPrViewModeSlidesSorter for the button with the action "Duplicate Slide" or by Braindump's SectionsBoxDock for the duplicate button)
> * by using no icon for the action "Merge with Layer Below"
> 
> So this fix is not perfect, but consistent how the problem of a missing "edit-duplicate" icon is solved in other places.
> 
> Okay to backport to 2.5?
> 
> 
> Diffs
> -----
> 
>   krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp 61141a3 
> 
> Diff: http://git.reviewboard.kde.org/r/105692/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120724/7fdb07fd/attachment.htm>