Review Request: fix KisPaintOpPresetsPopup to use an existing icon for the paintPresetIcon button
Boudewijn Rempt
boud at valdyas.org
Mon Jul 23 08:50:31 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105669/#review16261
-----------------------------------------------------------
I'm actually totally unsure what this button does... I'm not even sure it's actually visible.
- Boudewijn Rempt
On July 22, 2012, 3:48 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105669/
> -----------------------------------------------------------
>
> (Updated July 22, 2012, 3:48 p.m.)
>
>
> Review request for Calligra and Boudewijn Rempt.
>
>
> Description
> -------
>
> There is no "krita_paintop_icon" icon.
> From the existing icons "krita_tool_freehand" might come closest, so proposing to use that as substitute in this patch, arguing that the usual preset icon/preview is also some sketched freehand lines, so this icon can serve as a working symbol.
>
> Okay to backport to 2.5?
>
>
> Diffs
> -----
>
> krita/ui/widgets/kis_paintop_presets_popup.cpp 38e5d8a
>
> Diff: http://git.reviewboard.kde.org/r/105669/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120723/1da9c4fa/attachment.htm>
More information about the calligra-devel
mailing list