Review Request: Fix loading of embedded svg graphics.

Thorsten Zachmann t.zachmann at zagge.de
Wed Jul 18 06:15:48 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105589/
-----------------------------------------------------------

(Updated July 18, 2012, 5:15 a.m.)


Review request for Calligra and Jan Hambrecht.


Changes
-------

Moved the mimetype guessing to the KoOdfLoadingContext. It is activated by a flag so only use when it is needed.


Description
-------

This fixes loading of draw:image of the type svg in case the mimetype is not provided as in the document attached to the bug report.

When the mime type is not found we try to guess it by the content of the file. To do that we read the first 16K data and pass it to KMimeType.

After we found out the mime type we also set it so it is there for later usage.

Ok to backport to 2.5


This addresses bug 303587.
    http://bugs.kde.org/show_bug.cgi?id=303587


Diffs (updated)
-----

  libs/flake/svg/SvgShapeFactory.cpp 95602c0 
  libs/odf/KoOdfLoadingContext.h c8481ec 
  libs/odf/KoOdfLoadingContext.cpp 569cfd0 

Diff: http://git.reviewboard.kde.org/r/105589/diff/


Testing
-------

Tested with the above file and it is working nicely.

Please note that the svg is parsted into odf data structures and therefore we don't save the svg when we save the document.


Thanks,

Thorsten Zachmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120718/0d825a6d/attachment.htm>


More information about the calligra-devel mailing list