Review Request: rename the app icon of Calligra sheets from kspread to sheets
Friedrich W. H. Kossebau
kossebau at kde.org
Sun Jul 15 19:20:06 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105583/
-----------------------------------------------------------
Review request for Calligra, Marijn Kruisselbrink and C. Boemann.
Description
-------
The running Calligra sheets currently has as icon the "unknown" icon.
Reason is that the icon installed is still named "*-kspread" and also used by that name in all-but-one places.
This place is "AboutData", which has set as icon name the string "sheets", as by default set from the app id.
Also still using the id "kspread" for the icon is not perfect from a consistent appearance POV :)
Attached patch renames the installed icons to *-sheets and also adapts all places which used the "kspread" icon name.
(Only nitpick is that the actual icons are still the old ones from KOffice 1.* times(?), as the new ones are not yet done.
But those are still better than the "unknown" :) )
Okay to backport to 2.5?
Diffs
-----
active/qml/DocumentTypeSelector.qml 73fecf0
sheets/CMakeLists.txt 41ce521
sheets/data/pics/hi16-app-kspread.png 2fc3d86
sheets/data/pics/hi16-app-sheets.png PRE-CREATION
sheets/data/pics/hi22-app-kspread.png 9f8c807
sheets/data/pics/hi22-app-sheets.png PRE-CREATION
sheets/data/pics/hi32-app-kspread.png 5161357
sheets/data/pics/hi32-app-sheets.png PRE-CREATION
sheets/data/pics/hi48-app-kspread.png b908ae9
sheets/data/pics/hi48-app-sheets.png PRE-CREATION
sheets/part/CellToolFactory.cpp 4573c10
sheets/sheets.desktop af637b0
sheets/sheetspart.desktop 09f494e
Diff: http://git.reviewboard.kde.org/r/105583/diff/
Testing
-------
Thanks,
Friedrich W. H. Kossebau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120715/fe4baf62/attachment.htm>
More information about the calligra-devel
mailing list